Segment Replication - Recover all translog ops when flipping to able engine #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mch2
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
dreamer-89
approved these changes
Feb 17, 2023
| @@ -4314,7 +4314,7 @@ public void close() throws IOException { | |||
|
|
|||
| // When the new engine is created, translogs are synced from remote store onto local. Since remote store is the source | |||
| // of truth for translog, we play all translogs that exists locally. Otherwise, the recoverUpto happens upto global checkpoint. | |||
| long recoverUpto = this.isRemoteTranslogEnabled() ? Long.MAX_VALUE : globalCheckpoint; | |||
| long recoverUpto = this.isRemoteTranslogEnabled() || indexSettings().isSegRepEnabled() ? Long.MAX_VALUE : globalCheckpoint; | |||
There was a problem hiding this comment.
nit: Update comment providing details around why change is needed for segment replication ?
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6352 +/- ##
============================================
+ Coverage 70.73% 70.77% +0.03%
- Complexity 59024 59049 +25
============================================
Files 4800 4799 -1
Lines 282453 282421 -32
Branches 40718 40717 -1
============================================
+ Hits 199799 199889 +90
+ Misses 66259 66133 -126
- Partials 16395 16399 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…able engine. Signed-off-by: Marc Handalian <handalm@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6352-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c772596398d1646b48217214e3bc5904001413df
# Push it to GitHub
git push --set-upstream origin backport/backport-6352-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
dreamer-89
pushed a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Feb 18, 2023
…able engine. (opensearch-project#6352) Signed-off-by: Marc Handalian <handalm@amazon.com>
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Mar 4, 2023
…able engine. (opensearch-project#6352) Signed-off-by: Marc Handalian <handalm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #6314, when we flip to a writeable engine with SR we do not want to limit to the global checkpoint and rather recover all ops.
Issues Resolved
Related to flaky tests, these tests are still muted until WAIT_UNTIL issue has been fixed.
#6065
#5946
#5669
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.