Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] opensearch.opensearchplugin add groupID field to org.opensearch.plugin #534

Closed
Tracked by #2521
prudhvigodithi opened this issue Aug 29, 2022 · 3 comments
Assignees
Labels
good first issue Good for newcomers must_fix v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Aug 29, 2022

Description

The configuration modification for the gradle plugin opensearch.pluginzip to make sure the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file.

Related META issue

Part of: opensearch-project/opensearch-build#2521
From solution: opensearch-project/OpenSearch#3692

Current Behavior

The opensearch.opensearchplugin uses the default setting for groupId as org.opensearch.plugin, this when extended with open source community, it should be feasible to ammend the groupId as per required, hence for opensearch plugins the groupId should be mentioned as org.opensearch.plugin to make sure the opensearch plugins are published to this groupID and for other generic uses this can be extended to the custom groupId.

Expected Behavior

Once the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file, the plugin zips should continue to be published to the existing groupID.

Proposed solution

Solution from the PR: opensearch-project/OpenSearch#3692

@ankitkala
Copy link
Member

ankitkala commented Sep 13, 2022

We'll pick this up before 2.4 release.

@krishna-ggk krishna-ggk changed the title opensearch.opensearchplugin add groupID field to org.opensearch.plugin [ENHANCEMENT] opensearch.opensearchplugin add groupID field to org.opensearch.plugin Sep 14, 2022
@krishna-ggk krishna-ggk added the good first issue Good for newcomers label Sep 16, 2022
@ankitkala
Copy link
Member

@prudhvigodithi we just need to add a groupID: org.opensearch.plugin here right?
We don't need to change project.group here? Asking just for confirmation due to this.

Also, anything to verify/test here?

FYI: @sricharanvuppu will be working on this.

@prudhvigodithi
Copy link
Member Author

Closing this issue and groupID is now configured to the gradle project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers must_fix v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

No branches or pull requests

5 participants