Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][data-prepper] Support configurable image.registry #630

Closed
janhoy opened this issue Dec 5, 2024 · 2 comments · Fixed by #631
Closed

[Enhancement][data-prepper] Support configurable image.registry #630

janhoy opened this issue Dec 5, 2024 · 2 comments · Fixed by #631
Labels
enhancement New feature or request

Comments

@janhoy
Copy link
Contributor

janhoy commented Dec 5, 2024

Is your feature request related to a problem? Please describe.
Many organizations do not pull images from docker hub, but always thorugh a private registry (cache). Now, we have to modify image.repository to something like my.registry/opensearchproject/data-prepper.

Describe the solution you'd like
Follow the pattern from the opensearch char and offer a dockerRegistryvalue:

global:
  # Set if you want to change the default docker registry, e.g. a private one.
  dockerRegistry: ""

Describe alternatives you've considered
None

Additional context
None
@janhoy janhoy added enhancement New feature or request untriaged Issues that have not yet been triaged labels Dec 5, 2024
@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Dec 5, 2024
@prudhvigodithi
Copy link
Member

[Triage]
Thanks @janhoy I agree with we should support custom dockerRegistry, can you please contribute to the fix?
@peterzhuamazon @TheAlgo

@janhoy janhoy mentioned this issue Dec 10, 2024
Merged
3 tasks
@janhoy
Copy link
Contributor Author

janhoy commented Dec 17, 2024

@prudhvigodithi Did you have a chance to look at my PR?

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Engineering Effectiveness Board Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Engineering Effectiveness Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(chart/data-prepper): Add configurable global.dockerRegistry janhoy/opensearch-helm-charts
2 participants
@janhoy @prudhvigodithi