From f52c4431695fa9b5df14e44c16b4396913760426 Mon Sep 17 00:00:00 2001 From: zhichao-aws Date: Mon, 30 Oct 2023 11:30:49 +0800 Subject: [PATCH] fix ut Signed-off-by: zhichao-aws --- .../query/NeuralSparseQueryBuilderTests.java | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/src/test/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilderTests.java b/src/test/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilderTests.java index 8681deeb5..12e5394f9 100644 --- a/src/test/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilderTests.java +++ b/src/test/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilderTests.java @@ -88,7 +88,6 @@ public void testFromXContent_whenBuiltWithOptionals_thenBuildSuccessfully() { "VECTOR_FIELD": { "query_text": "string", "model_id": "string", - "max_token_score": 123.0, "boost": 10.0, "_name": "something", } @@ -99,7 +98,6 @@ public void testFromXContent_whenBuiltWithOptionals_thenBuildSuccessfully() { .startObject(FIELD_NAME) .field(QUERY_TEXT_FIELD.getPreferredName(), QUERY_TEXT) .field(MODEL_ID_FIELD.getPreferredName(), MODEL_ID) - .field(MAX_TOKEN_SCORE_FIELD.getPreferredName(), MAX_TOKEN_SCORE) .field(BOOST_FIELD.getPreferredName(), BOOST) .field(NAME_FIELD.getPreferredName(), QUERY_NAME) .endObject() @@ -112,7 +110,6 @@ public void testFromXContent_whenBuiltWithOptionals_thenBuildSuccessfully() { assertEquals(FIELD_NAME, sparseEncodingQueryBuilder.fieldName()); assertEquals(QUERY_TEXT, sparseEncodingQueryBuilder.queryText()); assertEquals(MODEL_ID, sparseEncodingQueryBuilder.modelId()); - assertEquals(MAX_TOKEN_SCORE, sparseEncodingQueryBuilder.maxTokenScore(), 0.0); assertEquals(BOOST, sparseEncodingQueryBuilder.boost(), 0.0); assertEquals(QUERY_NAME, sparseEncodingQueryBuilder.queryName()); } @@ -193,30 +190,6 @@ public void testFromXContent_whenBuildWithMissingQuery_thenFail() { expectThrows(IllegalArgumentException.class, () -> NeuralSparseQueryBuilder.fromXContent(contentParser)); } - @SneakyThrows - public void testFromXContent_whenBuildWithNegativeMaxTokenScore_thenFail() { - /* - { - "VECTOR_FIELD": { - "query_text": "string", - "model_id": "string", - "max_token_score": -1 - } - } - */ - XContentBuilder xContentBuilder = XContentFactory.jsonBuilder() - .startObject() - .startObject(FIELD_NAME) - .field(MODEL_ID_FIELD.getPreferredName(), MODEL_ID) - .field(MAX_TOKEN_SCORE_FIELD.getPreferredName(), -1f) - .endObject() - .endObject(); - - XContentParser contentParser = createParser(xContentBuilder); - contentParser.nextToken(); - expectThrows(IllegalArgumentException.class, () -> NeuralSparseQueryBuilder.fromXContent(contentParser)); - } - @SneakyThrows public void testFromXContent_whenBuildWithMissingModelId_thenFail() { /*