Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Support of new k-NN query parameter, expand_nested_docs #1008

Closed
heemin32 opened this issue Dec 10, 2024 · 3 comments · Fixed by #1013
Closed

[FEATURE]Support of new k-NN query parameter, expand_nested_docs #1008

heemin32 opened this issue Dec 10, 2024 · 3 comments · Fixed by #1013
Assignees

Comments

@heemin32
Copy link
Collaborator

heemin32 commented Dec 10, 2024

Is your feature request related to a problem?

In opensearch-project/k-NN#2283, a new parameter expand_nested_docs is added in k-nn query to support multi inner hits. I want it to be supported in neural search.

What solution would you like?

Support of expand_nested_docs parameter in neural search.

What alternatives have you considered?

Not supporting it.

Do you have any additional context?

Similar change has been made for a support of ef_search parameter. #814

@bzhangam
Copy link
Contributor

I'll work on this item.

@bzhangam
Copy link
Contributor

Hi @heemin32. I notice that in k-nn query the new field is called EXPAND_NESTED = "expand_nested_docs" but here you mention we want to add a new parameter extend_nested_docs. Wonder why we intend to use a different name? Should we also use expand_nested_docs in neural search for consistency?

@heemin32
Copy link
Collaborator Author

Hi @heemin32. I notice that in k-nn query the new field is called EXPAND_NESTED = "expand_nested_docs" but here you mention we want to add a new parameter extend_nested_docs. Wonder why we intend to use a different name? Should we also use expand_nested_docs in neural search for consistency?

My bad. we will use same name. expand_nested_docs

@heemin32 heemin32 changed the title [FEATURE]Support of new k-NN query parameter, extend_nested_docs [FEATURE]Support of new k-NN query parameter, expand_nested_docs Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants