-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Support #358
Comments
not applicable |
Adding Windows CI will ensure that the plugin actually works on Windows, we can't assume that it works because it's theoretically portable. |
@praveensameneni @qreshi Can you please update the status? |
I've drafted a PR for this, however, there are currently some failures that are being investigated:
|
An update, the issues above have been circumvented (among others) and currently the issues with the PR are:
I'm currently looking into the second issue first since I'd like all the CIs to at least run the tests first so we can verify if the tests are failing because of the difference in platform. |
The related PR has Cypress tests running for Windows, however, there is Cypress flakiness (and general issues with GitHub containers) that is not Windows specific causing test to fail sometimes. The general state of the PR is summarized in this comment. We can close out this issue after the PR is merged in but we'll be following up on the general test flakiness as a follow-up. |
Coming from opensearch-project/opensearch-plugins#95, add Windows support.
The text was updated successfully, but these errors were encountered: