Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #358

Closed
2 tasks
Tracked by #95
dblock opened this issue Oct 27, 2021 · 6 comments
Closed
2 tasks
Tracked by #95

Add Windows Support #358

dblock opened this issue Oct 27, 2021 · 6 comments
Assignees
Labels
v2.4.0 'Issues and PRs related to version v2.4.0' windows

Comments

@dblock
Copy link
Member

dblock commented Oct 27, 2021

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

  • Passing CI on Windows
  • Documentation
@anirudha
Copy link
Contributor

not applicable

@dblock
Copy link
Member Author

dblock commented Oct 30, 2021

Adding Windows CI will ensure that the plugin actually works on Windows, we can't assume that it works because it's theoretically portable.

@bbarani
Copy link
Member

bbarani commented Oct 26, 2022

@praveensameneni @qreshi Can you please update the status?

@bbarani bbarani added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 26, 2022
@qreshi
Copy link
Contributor

qreshi commented Oct 31, 2022

I've drafted a PR for this, however, there are currently some failures that are being investigated:

  1. The integTest and jacocoTestReport task need to be skipped for windows and mac as it faces failures otherwise. For some reason though I'm still seeing these tasks being called even with -x integTest -x jacocoTestReport
  2. There are some failures for the OSD Notifications build GitHub CI as well because it is complaining about some of the Unix commands that were being run not being available for the other OS environments. This can be investigated after the first issue is resolved since this task needs the backend plugin running successfully

@qreshi
Copy link
Contributor

qreshi commented Nov 1, 2022

An update, the issues above have been circumvented (among others) and currently the issues with the PR are:

  1. The backend workflow is for the most part successful but there are some test failures for the Windows run, we'll need to see if this is a flakey test or if there is a failure for some cases based on the platform
  2. The Notifications Dashboards workflow is hitting some errors when running the unit or Cypress tests due to build scripts not executing as intended on the Windows platform

I'm currently looking into the second issue first since I'd like all the CIs to at least run the tests first so we can verify if the tests are failing because of the difference in platform.

@qreshi
Copy link
Contributor

qreshi commented Nov 4, 2022

The related PR has Cypress tests running for Windows, however, there is Cypress flakiness (and general issues with GitHub containers) that is not Windows specific causing test to fail sometimes. The general state of the PR is summarized in this comment.

We can close out this issue after the PR is merged in but we'll be following up on the general test flakiness as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0' windows
Projects
None yet
Development

No branches or pull requests

5 participants