Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Heatmap visualization config panel features v1 #791

Closed
ruchika-narang opened this issue Jun 10, 2022 · 7 comments
Closed
Labels
enhancement New feature or request

Comments

@ruchika-narang
Copy link
Contributor

ruchika-narang commented Jun 10, 2022

Implementation of Heatmap config panel features as mentioned in opensearch-project/dashboards-observability#125 .

Features to implement:

  1. Panel options
  • Use common panel options.
  1. Data configurations
  • Use common data configurations for heatmap, but supports only 2 dimensions.
  1. Graph styles
@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric

For data configurations you have mentioned to support only 2 dimensions, but the in the current implementation of heatmap we have only one value option as z-axis. So are you referring to z-axis as dimensions or is there some other term for it. Also do we have to implement x-axis, y-axis and z-axis as data configurations for heatmap?

Thanks!
CC: @abasatwar @spattnaik

@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric @anirudha

I started working on legend for heatmap that is colorbar as per plotly's documentation. The current version of plotly that we are using(2.4.1), changing colorbar orientation is not supported yet. The Plotly provides support for colorbar orientation after version 2.8.0. So I have implemented show/hide of legend only. Let me know if that is okay.

Thanks!

CC: @abasatwar @spattnaik

@ruchika-narang
Copy link
Contributor Author

ruchika-narang commented Jun 15, 2022

Hi @mengweieric

I have begin working on the implementation of x-axis, y-axis and z-axis. When user has selected multiple x-axis and y-axis fields, the graph doesn't form.
I have passed in static data for x, y and z. X-axis has a 2D array, y-axis has a 2D array and z-axis is a 3D array. I think the data is not acceptable by this graph. Also I was looking around for some examples of heatmap, couldn't find any.
Can you please clarify the meaning of 2 dimensions as you mentioned in data configuration. Does that 2 dimension mean 1 x-axis field and 1 y-axis field or 2 x-axis field?

Also I am keeping the functionality of z-axis same where the user can only select one field.

Thanks!!
CC: @anirudha @abasatwar @spattnaik

@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric

Just wanted to confirm with you if we should move the value options for this graph to the right or let them be as in screenshot.
heatmap_dimensions

Thanks!

@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric

Just wanted to confirm one thing about this graph, as per our Thursday's call we would display no graph. Following will be the view on the initial load. Please let me know if this is expected.

heatmap_no_data

Thanks!

@anirudha
Copy link
Collaborator

yes, graph only works if we the relevant data and config

@ruchika-narang
Copy link
Contributor Author

This has been merged to the main branch in the PR: #824.
Legend placement is remaining for which a separate ticket will be created and will be linked to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants