Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Require the OpenAPI spec to be re-generated for pull requests #185

Closed
dblock opened this issue Jan 23, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Jan 23, 2024

What/Why

What are you proposing?

With the addition of coverage in #179 I propose we move the build into PRs as well.

  1. Make ./gradlew build output/overwrite OpenSearch.openapi.json at the root.
  2. Make CI fail if that file is not up-to-date.

What problems are you trying to solve?

Currently CI/CD re-generates the OpenAPI spec and makes a PR. This causes several issues.

What is the developer experience going to be?

Require that developers run ./gradlew build before a PR can be merged.

@dblock dblock added the enhancement New feature or request label Jan 23, 2024
@dblock dblock removed the untriaged label Feb 8, 2024
@nhtruong
Copy link
Collaborator

nhtruong commented Apr 2, 2024

@dblock will #211 resolve this one as well?

@dblock
Copy link
Member Author

dblock commented Apr 2, 2024

Yes, closing.

@dblock dblock closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants