Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add half_float sort queries in benchmark. #138

Closed
gashutos opened this issue Nov 3, 2023 · 0 comments
Closed

[FEATURE] Add half_float sort queries in benchmark. #138

gashutos opened this issue Nov 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@gashutos
Copy link
Contributor

gashutos commented Nov 3, 2023

Is your feature request related to a problem?

half_float field type is unique and we have custom comparators for this field. half_float is a mapping where BKD is indexed with 2 bytes while its doc values are stored as 4 bytes, so the sort logic comparison is divided in 2 ways, but still we were able to enable BKD point based optimization for this type.

What solution would you like?

nyc_taxis workload has many float type, tip_amount generally are between 0 to 100 $ and it should qualify as half_float. So making this field as half_float and adding asc & desc sort queries for this field will likely to improve our benchmarking coverage.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@gashutos gashutos added enhancement New feature or request untriaged labels Nov 3, 2023
@gkamat gkamat changed the title [FEATURE] Add half_float sort queires in benchmark. [FEATURE] Add half_float sort queries in benchmark. Nov 6, 2023
@gkamat gkamat removed the untriaged label Nov 6, 2023
@gkamat gkamat closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants