Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-Workload Improvements: Add Default Index Settings for Index.json #498

Open
IanHoang opened this issue Apr 1, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Low Priority

Comments

@IanHoang
Copy link
Collaborator

IanHoang commented Apr 1, 2024

When OSB creates a custom workload, the index.json only includes mappings from the referenced index and does not include default settings for index settings.

Each index.json should include default index settings.
Example:

  "settings": {
    "index.number_of_shards": {{number_of_shards | default(1)}},
    "index.number_of_replicas": {{number_of_replicas | default(0)}},
    "index.queries.cache.enabled": {{query_cache_enabled | default(false) | tojson}},
    "index.requests.cache.enable": {{requests_cache_enabled | default(false) | tojson}}
  },
@IanHoang
Copy link
Collaborator Author

IanHoang commented Apr 1, 2024

Added it to this RFC #395

@IanHoang IanHoang removed the untriaged label Apr 1, 2024
@IanHoang IanHoang changed the title Create-Workload: Add Default Index Settings for Index.json Create-Workload Improvements: Add Default Index Settings for Index.json Apr 1, 2024
@beaioun beaioun added 1.6.0 and removed 1.5.0 labels May 1, 2024
@IanHoang IanHoang removed the 1.6.0 label May 24, 2024
@IanHoang IanHoang self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants