Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically increment bwc version #3063

Closed
kaituo opened this issue Jan 9, 2023 · 7 comments
Closed

automatically increment bwc version #3063

kaituo opened this issue Jan 9, 2023 · 7 comments
Labels
enhancement New Enhancement

Comments

@kaituo
Copy link

kaituo commented Jan 9, 2023

Is your feature request related to a problem? Please describe

We need to bump the bwc version in every release (example: opensearch-project/anomaly-detection#775) because only the latest N-1.x will be upgradable to N.0 (e.g., from 2.x to 3.0) when that ships.

Known issue: opensearch-project/OpenSearch#5076
latest development: opensearch-project/OpenSearch#5091

Describe the solution you'd like

Could you automate bumping bwc version similar to release version (e.g., opensearch-project/anomaly-detection#774)?

Describe alternatives you've considered

No response

Additional context

No response

@kaituo kaituo added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 9, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Jan 10, 2023

Hi @kaituo,

You can do that by updating the updateVersion task in your build.gradle file. You can tell the task what all it needs to update https://github.com/opensearch-project/anomaly-detection/blob/main/build.gradle#L793-L802
For example, check this notification plugin repo's task https://github.com/opensearch-project/notifications/blob/main/notifications/build.gradle#L115-L130 it updates even the github workflows.

Let us know if this solves your problem. Thanks!

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Jan 10, 2023
@zelinh
Copy link
Member

zelinh commented Jan 10, 2023

I think we could use opensearch_version from gradle properties for this one. Our current version bump workflow is incrementing this version everytime and this is pretty much the same as the version used for bwc. Only difference I'm thinking right now would be the -SNAPSHOT suffix.
I could elaborate this PR opensearch-project/anomaly-detection#778 to accommodate the changes.

@kaituo
Copy link
Author

kaituo commented Jan 24, 2023

Thanks @gaiksaya Thanks for the link.

@zelinh Thanks for doing it. As we are using latest 2.x for 3.x bwc testing, whenever we increment 2.x version we need to update the bwc version in 3.x.

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jan 26, 2023

Related open issue #2373
@gaiksaya @zelinh @kaituo

@bbarani
Copy link
Member

bbarani commented Jan 31, 2023

@prudhvigodithi @zelinh Whats the next step to move forward?

@prudhvigodithi
Copy link
Member

A solution added by k-nn team https://github.com/opensearch-project/k-NN/blob/2.x/build.gradle#L327, that can increment the bwc version in the same existing gradle task updateVersion, sample PR for incrementing BWC version https://github.com/opensearch-project/k-NN/pull/826/files.
@ankitkala @peternied

@gaiksaya
Copy link
Member

gaiksaya commented Jan 5, 2024

Closing this issue as no action item is pending from this repo. Please feel free to update the updateVersion task in order to accommodate more updates you version number in your repo. All the build-repo does is runs that tasks.

@gaiksaya gaiksaya closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants