-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split, simplify and move usage of CI runners between OpenSearch and OpenSearch Dashboards #732
Comments
Additionally, it would be great to have images for:
In case there is a question which JDK distributions to use, https://adoptium.net/ would make it. @peterzhuamazon @peternied could you please help, thank you! |
Should we be a) installing JDK part of the build instead to minimize all these images, or b) making an image that contains all the JDKs pre-installed and having scripts select one? We can use sdk to install for example. |
We certainly could do that, pre-baking the images has the benefits that we don't need to download and install JDKs every time (+ |
The starting point to add dockerfiles to create those docker images would be https://github.com/opensearch-project/opensearch-build/tree/main/docker/ci/dockerfiles |
Thanks. |
Thanks @peterzhuamazon , just to summarize: it is easier to bake 1-2 all-in-one images (with multiple JDKs) than have the dedicated ones. It believe it should work. Do you have time to update the |
Free free to contribute. I will take a deeper look next week. |
@peterzhuamazon thanks a lot for merging the PRs, could you please ping us when the new images are available so we could alter the build pipelines to use the per-branch JDK specifications, thank you! |
Will ping. |
@reta |
How did we build these images? Manually or is that automated somewhere? |
Instructions in default README I will work on automation next week. |
@peternied @peterzhuamazon @dblock so we have images, manifests and |
Looks like we broke something - @kavilla said in a private chat: "seems like the docker stage will need an agent defined to do the work of reading the yaml file. which might defeat the purpose of just using a predefined docker agent to read the manifest for the docker agent" - someone will dig up the error(s) today and let's fix it |
that Jenkins being still private, @peternied can help coordinate and make sure this all works next |
I want to be able to close #74 |
I would expect that YAML manifest is read on master (since the agent is set to |
Definitely no need to apologize. It's on us that this infrastructure is private, we're working on it. |
Looking into this 👀 If you are interested in contributing to that system checkout opensearch-ci |
Is your feature request related to a problem? Please describe
CI runners are the kitchen sink of everything to support OpenSearch and OpenSearch Dashboards. We will run into conflicts sooner than later. We will also want to build multiple versions at the same time which will make it difficult to track what's what. For example, in
centos7-x64-arm64-jdk14-node10.24.1-cypress6.9.1-20211005
, OpenSearch doesn't need node or cypress, while OpenSearch Dashboards doesn't need Java. Then, we're going to lower the Java version for OpenSearch, so we'll need to use multiple images.Describe the solution you'd like
centos7-x64-arm64-jdk14
andcentos7-x64-arm64-node10.24.1-cypress6.9.1
.The text was updated successfully, but these errors were encountered: