[MD] functional test for datasource creation page #316

yibow98 · 2022-09-30T17:22:20Z

Signed-off-by: Yibo Wang yibow@amazon.com

Description

Functional test for datasource creation page

1_create_datasource.spec.copy.js.mp4

Issues Resolved

opensearch-project/OpenSearch-Dashboards#2576
#337

To do:

Create a test domain and update the endpoint URL environment variable. Currently is a dummy URL for testing.

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tianleh · 2022-10-03T23:04:46Z

check my comment on this PR #314 (comment) Could you sync up with @mpabba3003 to see who can create the feature flag first?

yibow98 · 2022-10-03T23:27:57Z

check my comment on this PR #314 (comment) Could you sync up with @mpabba3003 to see who can create the feature flag first?

Sure! Will do.

noCharger · 2022-10-06T15:29:09Z

Will this PR depends on opensearch-project/OpenSearch-Dashboards#2501?

yibow98 · 2022-10-06T16:25:55Z

Will this PR depends on opensearch-project/OpenSearch-Dashboards#2501?

Yes, will modify the tests after PR merge into main.

...oards/vanilla-opensearch-dashboards/datasource-management-plugin/1_create_datasource.spec.js

noCharger

Excellent job figuring out the configuration override. Can we provide more descriptive messages in describe() instead of adding comments to test cases?

cypress.json

.github/workflows/release-e2e-workflow-template.yml

noCharger · 2022-10-15T01:20:52Z

cypress.json

-    "VISBUILDER_ENABLED": false
+    "VISBUILDER_ENABLED": false,
+    "DATASOURCE_MANAGEMENT_ENABLED": false,
+    "OSD_TEST_DOMAIN_ENDPOINT_URL": "https://test",


do we really need the endpoint as constant in cypress.json? I would prefer either use github secret if it's actual endpoint or constant string in test cases

In my local, I used environment variable to define the URL and the current OSD_TEST_DOMAIN_ENDPOINT_URL is a dummy url. We will create an official test domain later and use github secret then.

Interesting problem! I am ok to move forward for now.

We may need to brainstorm a bit how to support such when the tests run from our org's infra team https://github.com/opensearch-project/opensearch-build cc @seraphjiang @kavilla @CCongWang @kristenTian

yibow98 · 2022-10-17T17:08:06Z

Excellent job figuring out the configuration override. Can we provide more descriptive messages in describe() instead of adding comments to test cases?

I think the current description in describe is clear for each test case. The reason I add comments is that I want to make it more readable. The comments are same as messages in describe() .

tianleh · 2022-10-18T00:45:25Z

Could you check this comment to see if you can run the workflow against 2.4.0?

#325 (comment)

yibow98 · 2022-10-18T02:42:23Z

Could you check this comment to see if you can run the workflow against 2.4.0?

#325 (comment)

Sure thing! Will do it.

yibow98 · 2022-10-18T17:05:38Z

Could you check this comment to see if you can run the workflow against 2.4.0?

#325 (comment)

I raised a PR #335 against 2.x branch and the Bundle Snapshot based E2E Cypress tests workflow for core Dashboards" is successful against 2.4.0. Reference: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3275360924/jobs/5390106545. Please ignore the one of cypress test case failed, I will fix it in my code. All other check pass.

tianleh · 2022-10-18T19:27:35Z

Is backport to 2.x needed? If yes, please add such label. See this example. #325 With this label, it will automatically create a new PR to backport after your current PR is merged.

yibow98 · 2022-10-18T19:30:59Z

Is backport to 2.x needed? If yes, please add such label. See this example. #325 With this label, it will automatically create a new PR to backport after your current PR is merged.

Added!

tianleh · 2022-10-18T19:37:55Z

Please sync from main and resolve the conflict. @yibow98

yibow98 · 2022-10-18T19:51:24Z

Please sync from main and resolve the conflict. @yibow98

Done

.github/workflows/cypress-workflow-bundle-snapshot-based.yml

cypress.json

tianleh

You can git checkout those two files. Ideally they shall not show up in the diff.

Signed-off-by: Yibo Wang <yibow@amazon.com>

yibow98 · 2022-10-18T20:17:59Z

You can git checkout those two files. Ideally they shall not show up in the diff.

Solved. Now it should be ready to be merged. Thanks!

* [MD] functional test for datasource creation page Signed-off-by: Yibo Wang <yibow@amazon.com> * Set up environment variables for endpoint url and username&password Signed-off-by: Yibo Wang <yibow@amazon.com> * Update functional test & add a feature flag Signed-off-by: Yibo Wang <yibow@amazon.com> * Resolved comments Signed-off-by: Yibo Wang <yibow@amazon.com> * Move url variable to constant.js & remove some comments in code Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 7755b38)

…#316) * [MD] functional test for datasource creation page Signed-off-by: Yibo Wang <yibow@amazon.com> * Set up environment variables for endpoint url and username&password Signed-off-by: Yibo Wang <yibow@amazon.com> * Update functional test & add a feature flag Signed-off-by: Yibo Wang <yibow@amazon.com> * Resolved comments Signed-off-by: Yibo Wang <yibow@amazon.com> * Move url variable to constant.js & remove some comments in code Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>

yibow98 requested a review from a team as a code owner September 30, 2022 17:22

noCharger reviewed Oct 14, 2022

View reviewed changes

...oards/vanilla-opensearch-dashboards/datasource-management-plugin/1_create_datasource.spec.js Outdated Show resolved Hide resolved

yibow98 self-assigned this Oct 14, 2022

yibow98 requested review from zengyan-amazon, kristenTian, zhongnansu, mpabba3003, noCharger and tianleh October 14, 2022 23:37

noCharger reviewed Oct 15, 2022

View reviewed changes

yibow98 mentioned this pull request Oct 18, 2022

Functional test for datasource creation page #335

Closed

1 task

tianleh approved these changes Oct 18, 2022

View reviewed changes

yibow98 added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 18, 2022

yibow98 added the backport 2.x label Oct 18, 2022

kristenTian approved these changes Oct 18, 2022

View reviewed changes

CCongWang approved these changes Oct 18, 2022

View reviewed changes

tianleh reviewed Oct 18, 2022

View reviewed changes

.github/workflows/cypress-workflow-bundle-snapshot-based.yml Outdated Show resolved Hide resolved

tianleh reviewed Oct 18, 2022

View reviewed changes

cypress.json Outdated Show resolved Hide resolved

tianleh requested changes Oct 18, 2022

View reviewed changes

yibow98 added 5 commits October 18, 2022 12:58

[MD] functional test for datasource creation page

069f7d0

Signed-off-by: Yibo Wang <yibow@amazon.com>

Set up environment variables for endpoint url and username&password

6afad20

Signed-off-by: Yibo Wang <yibow@amazon.com>

Update functional test & add a feature flag

6027090

Signed-off-by: Yibo Wang <yibow@amazon.com>

Resolved comments

2df03ad

Signed-off-by: Yibo Wang <yibow@amazon.com>

Move url variable to constant.js & remove some comments in code

9bc7955

Signed-off-by: Yibo Wang <yibow@amazon.com>

tianleh approved these changes Oct 18, 2022

View reviewed changes

tianleh merged commit 7755b38 into opensearch-project:main Oct 18, 2022

opensearch-trigger-bot bot mentioned this pull request Oct 18, 2022

[Backport 2.x] [MD] functional test for datasource creation page #339

Merged

tianleh pushed a commit that referenced this pull request Oct 19, 2022

[MD] functional test for datasource creation page (#316) (#339)

6e9bca1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] functional test for datasource creation page #316

[MD] functional test for datasource creation page #316

yibow98 commented Sep 30, 2022 •

edited

Loading

tianleh commented Oct 3, 2022

yibow98 commented Oct 3, 2022

noCharger commented Oct 6, 2022

yibow98 commented Oct 6, 2022

noCharger left a comment

noCharger Oct 15, 2022

yibow98 Oct 17, 2022

tianleh Oct 18, 2022

yibow98 commented Oct 17, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh left a comment

yibow98 commented Oct 18, 2022

[MD] functional test for datasource creation page #316

[MD] functional test for datasource creation page #316

Conversation

yibow98 commented Sep 30, 2022 • edited Loading

Description

Issues Resolved

To do:

Check List

tianleh commented Oct 3, 2022

yibow98 commented Oct 3, 2022

noCharger commented Oct 6, 2022

yibow98 commented Oct 6, 2022

noCharger left a comment

Choose a reason for hiding this comment

noCharger Oct 15, 2022

Choose a reason for hiding this comment

yibow98 Oct 17, 2022

Choose a reason for hiding this comment

tianleh Oct 18, 2022

Choose a reason for hiding this comment

yibow98 commented Oct 17, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh commented Oct 18, 2022

yibow98 commented Oct 18, 2022

tianleh left a comment

Choose a reason for hiding this comment

yibow98 commented Oct 18, 2022

yibow98 commented Sep 30, 2022 •

edited

Loading