[BUG] dense_vector instead of knn_vector

[rogeriochaves]

What is the bug?

The index builder has the dense_vector property (https://www.javadoc.io/doc/org.opensearch.client/opensearch-java/latest/org/opensearch/client/opensearch/_types/mapping/DenseVectorProperty.html), but dense_vector doesn't actually exists on OpenSearch, only on ES, if I try to use it, I get a 400.

On OpenSearch, it should actually be knn_vector, as it was decided on this RFC (opensearch-project/OpenSearch#3545), but this option is not available

How can one reproduce the bug?

Kotlin code:

        builder
            .properties(indexedProductSemanticVectorKey) { p ->
                p.denseVector(
                    DenseVectorProperty.of { d ->
                        d.dims(1536)
                    }
                )
            }

What is the expected behavior?

To have a knn option available, or that the denseVector one just works

What is your host/environment?

AWS

[wbeckler]

good catch. Feel free to PR a fix.

[wisocn]

Bumping this for visibility - got the same exact issue today

[maltehedderich]

I am going to start working on this issue now.

Should I also remove the dense vector property and therefore introduce some incompatibility with ES or just add the knn_vector property and index settings?

All property files are prefixed with THIS CODE IS GENERATED. MANUAL EDITS WILL BE LOST. but I could not find any reference to the generator for this. Is the comment outdated or where can I find the generator?

[rogeriochaves]

this worked well for us in the new version of the lib, thank you very much