Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Automate bumping versions after releases #81

Open
Tracked by #34
harshavamsi opened this issue Sep 8, 2022 · 5 comments
Open
Tracked by #34

[FEATURE] Automate bumping versions after releases #81

harshavamsi opened this issue Sep 8, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@harshavamsi
Copy link
Collaborator

Is your feature request related to a problem?

Coming from opensearch-project/opensearch-clients#34. The version should be bumped each time a release is made so that builds happen for new changes with appropriate versioning.

What solution would you like?

Implement workflow similar to https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/version.yml

@shyim
Copy link
Collaborator

shyim commented Oct 29, 2022

I am not really sure if we need that. We have to just create a new Release at Github and it's done 😅

@dblock
Copy link
Member

dblock commented Nov 1, 2022

Where's the version stored in code? Is it?

@dblock
Copy link
Member

dblock commented Apr 19, 2024

So the version is not stored in the code, but should, I opened #182.

@dblock
Copy link
Member

dblock commented Apr 24, 2024

Here's what automation should produce: #190.

@saimedhi
Copy link
Collaborator

saimedhi commented May 23, 2024

Here's what automation should produce: #190.

In the future, once we transition to generating client using templates, let's aim to modify the client version in util/template/client-class, rather than in src/OpenSearch/Client.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants