Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX/OUI] Move global styles header breadcrumb to OUI #22

Closed
kaddy645 opened this issue Jul 28, 2022 · 5 comments · Fixed by #131
Closed

[UX/OUI] Move global styles header breadcrumb to OUI #22

kaddy645 opened this issue Jul 28, 2022 · 5 comments · Fixed by #131
Assignees

Comments

@kaddy645
Copy link
Contributor

kaddy645 commented Jul 28, 2022

The breadcrumb restyling completed in opensearch-project/OpenSearch-Dashboards#1954 should be migrated here to become the new default OUI breadcrumb styles. Because we'll have full control of the component here, we'll likely want to refactor the breadcrumbs entirely, not just apply the patched styles.

After implemented then create issue in OpenSearch Dashboards to utilize the new breadcrumbs

Requirements:

  • Styling in OUI for the new breadcrumbs
  • New property to switch between the two
  • Documentation updated (?)
@kaddy645 kaddy645 changed the title > Move global styles header breadcrumb to OUI [UX/OUI] Move global styles header breadcrumb to OUI Jul 28, 2022
@kavilla kavilla transferred this issue from opensearch-project/OpenSearch-Dashboards Aug 5, 2022
@kavilla
Copy link
Member

kavilla commented Aug 12, 2022

@KrooshalUX will add more context, for example sizing.

@kavilla
Copy link
Member

kavilla commented Aug 15, 2022

@KrooshalUX could we get the finalized colors? Thank you!!

@KrooshalUX
Copy link
Contributor

@kavilla the colors are finalized. Can you specify what you think may be missing ?

@KrooshalUX
Copy link
Contributor

The design adjustment that is remaining is to make the left padding of the first breadcrumb 8px vs 12px which it is currently implemented as. Previously with EUI we were locked in to using even padding on r&l. With moving to OUI we should now be able to customize those values.

@KrooshalUX KrooshalUX moved this to Icebox (No Dev) in OUI Components Nov 1, 2022
@KrooshalUX KrooshalUX assigned BSFishy and unassigned kaddy645 Nov 8, 2022
@ashwin-pc
Copy link
Member

@BSFishy what are some of the approaches you have tried and why did you decide against them? clip-path is my preferred approach here.

@kavilla kavilla linked a pull request Feb 21, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Icebox : Do Not Action to Done in OUI Components Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants