Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Usages of actionGet API Call #1336

Closed
adityaj1107 opened this issue Jul 23, 2021 · 1 comment
Closed

Review Usages of actionGet API Call #1336

adityaj1107 opened this issue Jul 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@adityaj1107
Copy link

Describe the bug
Review usages of actionGet API calls so that this API if being called in a single threaded pool should use timeouts or should be called asynchronously.

PRs in alerting (opensearch-project/alerting#130) and index management (opensearch-project/index-management#100) where we have replaced the usages of the actionGet API calls which are blocking in nature and block the execution of the program with the callback listeners for the API call response. Using this API with time outs is okay but the execution should be made asynchronous.

Sample Usage in Security:

final AcknowledgedResponse response = tc.admin().indices().updateSettings((new UpdateSettingsRequest(index).settings(indexSettings))).actionGet();

We should review all such usages.

@adityaj1107 adityaj1107 added Beta bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 23, 2021
@peternied peternied removed the Beta label Apr 8, 2022
@davidlago davidlago removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Apr 12, 2022
@davidlago
Copy link

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).

If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants