-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags to be used for security plugin releases #1406
Comments
Adding @peterzhuamazon @dblock to continue the discussion that started in GA release readiness. |
I suggest opening a PR proposal into https://github.com/opensearch-project/.github/blob/main/RELEASING.md and discussing it there? Once merged we can call it "agreement". There's some discussion on tags in opensearch-project/.github#13 and I believe 1.0 has been tagged with a certain scheme in mind already, so I would start by matching that closely. |
The existing scheme for OpenSearch 1.0 will not work for the security plugin and I strongly recommend not to use it for other repos as well. The majority of open source projects use either |
The issue is that the current scheme (n.n.n.n) makes it difficult if not impossible for GitHub CD pipeline in the security plugin to distinguish a release tag from any other tag. That pipeline today triggers builds on tags starting with v. |
To clarify, currently, security plugin's CD is triggered by tags starting with |
Closing issue as we have settled on a version/tag standard project-wide. |
Versions of the security plugin were reset to 1.x after move to OpenSearch. It is necessary to agree on the tag naming convention as
v.1.x.x.x
scheme conflicts with the existing tags for ODFE releases. We can either switch torelease-1.x.x.x
scheme or usev1.x.x.x-OS
scheme. Any other options?The text was updated successfully, but these errors were encountered: