Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags to be used for security plugin releases #1406

Closed
vrozov opened this issue Aug 16, 2021 · 6 comments
Closed

Tags to be used for security plugin releases #1406

vrozov opened this issue Aug 16, 2021 · 6 comments
Labels
maintenance Project maintenance

Comments

@vrozov
Copy link
Contributor

vrozov commented Aug 16, 2021

Versions of the security plugin were reset to 1.x after move to OpenSearch. It is necessary to agree on the tag naming convention as v.1.x.x.x scheme conflicts with the existing tags for ODFE releases. We can either switch to release-1.x.x.x scheme or use v1.x.x.x-OS scheme. Any other options?

@vrozov vrozov added the maintenance Project maintenance label Aug 16, 2021
@cliu123
Copy link
Member

cliu123 commented Aug 16, 2021

Adding @peterzhuamazon @dblock to continue the discussion that started in GA release readiness.

@dblock
Copy link
Member

dblock commented Aug 16, 2021

I suggest opening a PR proposal into https://github.com/opensearch-project/.github/blob/main/RELEASING.md and discussing it there? Once merged we can call it "agreement". There's some discussion on tags in opensearch-project/.github#13 and I believe 1.0 has been tagged with a certain scheme in mind already, so I would start by matching that closely.

@vrozov
Copy link
Contributor Author

vrozov commented Aug 16, 2021

The existing scheme for OpenSearch 1.0 will not work for the security plugin and I strongly recommend not to use it for other repos as well. The majority of open source projects use either v.x.x.x scheme or release-x.x.x scheme or project-x.x.x scheme.

@dblock
Copy link
Member

dblock commented Aug 30, 2021

The issue is that the current scheme (n.n.n.n) makes it difficult if not impossible for GitHub CD pipeline in the security plugin to distinguish a release tag from any other tag. That pipeline today triggers builds on tags starting with v.

@cliu123
Copy link
Member

cliu123 commented Sep 8, 2021

The issue is that the current scheme (n.n.n.n) makes it difficult if not impossible for GitHub CD pipeline in the security plugin to distinguish a release tag from any other tag.

To clarify, currently, security plugin's CD is triggered by tags starting with v . Tags not starting with v don't trigger CD with the configuration that security plugin currently has because they are not considered as release tags. If we decide to remove v from release tags, the format of tags to trigger CD will need to be changed like this (line 6 in cd.yml file), which means all tags will trigger CD workflow.
While almost all the tags that we currently have start with v , which means almost all the tags are considered as release tags, the concern mentioned above on this is that there might be tags that are not release tags at some point in the future, it'd be not easy to distinguish release tags from non-release tags without adding v as prefix in release tags.

@davidlago
Copy link

Closing issue as we have settled on a version/tag standard project-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

No branches or pull requests

4 participants