From 063d0af54919aaca13e4425b5eb6d72fed1ca32c Mon Sep 17 00:00:00 2001
From: Juan Hernandez <jhernand@redhat.com>
Date: Thu, 15 Aug 2019 16:43:46 +0300
Subject: [PATCH] Option `--url` is not mandatory

In a recent patch we replaced `os.Exit(...)` with the Cobra error
handling mechanism. A side effect of that change is that the `--url`
option was marked as mandatory. This makes the application fail if it
isn't explicity used even if it has a default value. This patch changes
the application so that it isn't mandatory. Instead we just check that
it isn't empty.

Related: https://github.com/openshift-online/uhc-cli/issues/61
Signed-off-by: Juan Hernandez <jhernand@redhat.com>
---
 cmd/uhc/login/cmd.go | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/cmd/uhc/login/cmd.go b/cmd/uhc/login/cmd.go
index d20be35..f163adb 100644
--- a/cmd/uhc/login/cmd.go
+++ b/cmd/uhc/login/cmd.go
@@ -66,8 +66,6 @@ var Cmd = &cobra.Command{
 }
 
 func init() {
-	var err error
-
 	flags := Cmd.Flags()
 	flags.StringVar(
 		&args.tokenURL,
@@ -110,11 +108,6 @@ func init() {
 		client.DefaultURL,
 		"URL of the API gateway.",
 	)
-	err = Cmd.MarkFlagRequired("url")
-	if err != nil {
-		fmt.Fprintf(os.Stderr, "Can't mark flag as required: %v\n", err)
-		os.Exit(1)
-	}
 	flags.StringVar(
 		&args.token,
 		"token",
@@ -154,6 +147,11 @@ func init() {
 func run(cmd *cobra.Command, argv []string) error {
 	var err error
 
+	// Check mandatory options:
+	if args.url == "" {
+		return fmt.Errorf("Option '--url' is mandatory")
+	}
+
 	// Check that we have some kind of credentials:
 	havePassword := args.user != "" && args.password != ""
 	haveSecret := args.clientID != "" && args.clientSecret != ""