From 0f7beeb01982c97bd1abcb41fd65186a61e75a74 Mon Sep 17 00:00:00 2001 From: logonoff Date: Wed, 4 Dec 2024 21:49:23 -0500 Subject: [PATCH] CONSOLE-3905: (dynamic-plugin-sdk) share webpack resolution with main repo --- frontend/packages/console-dynamic-plugin-sdk/package.json | 3 +-- .../scripts/package-definitions.ts | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/frontend/packages/console-dynamic-plugin-sdk/package.json b/frontend/packages/console-dynamic-plugin-sdk/package.json index 72b61fa675b..b7affbc7cdb 100644 --- a/frontend/packages/console-dynamic-plugin-sdk/package.json +++ b/frontend/packages/console-dynamic-plugin-sdk/package.json @@ -23,7 +23,6 @@ "ejs": "3.x", "fs-extra": "9.x", "ts-json-schema-generator": "0.98.0", - "tsutils": "3.21.0", - "webpack": "^5.75.0" + "tsutils": "3.21.0" } } diff --git a/frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts b/frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts index dd9c675f8b5..44786560b2c 100644 --- a/frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts +++ b/frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts @@ -157,14 +157,10 @@ export const getWebpackPackage: GetPackageDefinition = ( main: 'lib/lib-webpack.js', ...commonManifestFields, dependencies: { - ...parseDeps( - sdkPackage, - ['@openshift/dynamic-plugin-sdk-webpack', 'webpack'], - missingDepCallback, - ), + ...parseDeps(sdkPackage, ['@openshift/dynamic-plugin-sdk-webpack'], missingDepCallback), ...parseDeps( rootPackage, - ['ajv', 'chalk', 'comment-json', 'find-up', 'glob', 'read-pkg', 'semver'], + ['ajv', 'chalk', 'comment-json', 'find-up', 'glob', 'read-pkg', 'semver', 'webpack'], missingDepCallback, ), ...parseDepsAs(rootPackage, { 'lodash-es': 'lodash' }, missingDepCallback),