Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic plugin: A custom tab in the project's horizontal navigation is overriding the Overview tab #13899

Open
bartoval opened this issue May 27, 2024 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bartoval
Copy link

bartoval commented May 27, 2024

Both in my plugin and when launching the dynamic-plugin-demo, I noticed this effect:

  1. The first 'Overview' tab is highlighted instead of my custom tab, and it displays the content of my project
  2. If I click on the custom tab, the path keeps getting appended in the browser's URL (only Chrome)
  3. Clicking on the "Demo Plugin" tab and then switching to a different tab doesn't update the URL path.
    This keeps the path at "/demo-plugin/" and break the navigation to the other sections of the application.

demo-plugin

I am running OCP 4.15 and the dynamic plugin demo with these deps:
@openshift-console/dynamic-plugin-sdk": "^1.3.0", "@openshift-console/dynamic-plugin-sdk-webpack": "^1.1.0", "@openshift-console/plugin-shared": "^0.0.3",

@spadgett
Copy link
Member

/assign @vojtechszocs @jhadvig
/kind bug

@spadgett spadgett added the kind/bug Categorizes issue or PR as related to a bug. label Jul 12, 2024
@bartoval
Copy link
Author

bartoval commented Jul 12, 2024

Hello,
Just last night I managed to get the correct behavior in this new Plugin version, by removing the initial '/' in the console-extensions.json.

{
  "type": "console.tab/horizontalNav",
    ....
         href": "your-path" 
   ....
}

instead
"href": "/your-path"

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants