Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify openstackCredsFile #550

Closed
sallyom opened this issue Oct 26, 2018 · 2 comments
Closed

Verify openstackCredsFile #550

sallyom opened this issue Oct 26, 2018 · 2 comments
Assignees

Comments

@sallyom
Copy link
Contributor

sallyom commented Oct 26, 2018

Platform openstack:

With this PR, #427 need to verify that the correct file to get OpenStack creds is this: /etc/openstack/clouds.yaml. Another option would be openStackCredsFile = os.Getenv("HOME") + "/.config/openstack"

Once the OpenStack folks verify, this issue can be closed.

With an OpenStack launch of installer, you will see a secret openstack-creds in -n kube-system with encoded clouds.yaml in the data of the secret. Might want to add multiple files/conditional to what creds file is found on the host system during launch in that secret.

@wking
Copy link
Member

wking commented Oct 27, 2018

The existing pattern (e.g. for pull secrets and SSH pubkeys) is to try and pick a sane default, but to have a wizard prompt when we aren't sure and an environment variable to override. That seems sane to me, if we have doubts about our automatic-detection logic. And even if we do get that wrong, folks can now do a multi-step install to slot in the creds they wish we'd found :).

@flaper87
Copy link
Contributor

/assign @flaper87

flaper87 added a commit to flaper87/installer that referenced this issue Nov 1, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a `clouds.yaml` under `/etc/openstack`.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 1, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a `clouds.yaml` under `/etc/openstack`.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 2, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a `clouds.yaml` under `/etc/openstack`.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 2, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a `clouds.yaml` under `/etc/openstack`.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 5, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 5, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 8, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 8, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 8, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
flaper87 added a commit to flaper87/installer that referenced this issue Nov 13, 2018
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.

Note that deployments on OpenStack are currently broken unless there's
a clouds.yaml under /etc/openstack.

Fixes openshift#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants