From 5e4086ed4db511525d001ab39dc87a9a6f312704 Mon Sep 17 00:00:00 2001 From: Chad Scribner Date: Fri, 26 May 2023 14:49:49 -0400 Subject: [PATCH 1/5] cleanup: remove golanglintci todo This TODO is dependent on a change in golangci-lint-action which hasn't seen any action since before April 2022. Safe to assume this won't be completed and leaving the --skip-files flag is a noop. --- .github/workflows/golangci-lint.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yaml b/.github/workflows/golangci-lint.yaml index 465fec236..5d8e1edbe 100644 --- a/.github/workflows/golangci-lint.yaml +++ b/.github/workflows/golangci-lint.yaml @@ -32,7 +32,6 @@ jobs: # working-directory: somedir # Optional: golangci-lint command line arguments. - # TODO: remove --skip-files once logic is implemented # NO_FUTURE args from https://github.com/golangci/golangci-lint-action/issues/119 args: > --out-${NO_FUTURE}format colored-line-number -E gosec --timeout=6m --skip-files From 967edb8d45f004f1715c26b182b7735fbf1cfa57 Mon Sep 17 00:00:00 2001 From: Chad Scribner Date: Fri, 26 May 2023 14:51:47 -0400 Subject: [PATCH 2/5] cleanup: remove lvm config todo We agreed that we would not implement low-level lvm config into the operator because it introduced too many iterations of test scenarios that would need to be covered. We'll instead adjust the API to fit specific scenarios on an as-needed basis. --- api/v1alpha1/lvmcluster_types.go | 5 ----- api/v1alpha1/lvmvolumegroup_types.go | 5 ----- 2 files changed, 10 deletions(-) diff --git a/api/v1alpha1/lvmcluster_types.go b/api/v1alpha1/lvmcluster_types.go index 76d6f0e09..9198e12ea 100644 --- a/api/v1alpha1/lvmcluster_types.go +++ b/api/v1alpha1/lvmcluster_types.go @@ -82,11 +82,6 @@ type DeviceClass struct { // +optional NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"` - // TODO: add support for various LVM settings - // // Config for this deviceClass, lvm settings are a field here - // // +optional - // Config *DeviceClassConfig `json:"config,omitempty"` - // ThinPoolConfig contains configurations for the thin-pool // +kubebuilder:validation:Required // +required diff --git a/api/v1alpha1/lvmvolumegroup_types.go b/api/v1alpha1/lvmvolumegroup_types.go index c46fa02c5..2766f6a47 100644 --- a/api/v1alpha1/lvmvolumegroup_types.go +++ b/api/v1alpha1/lvmvolumegroup_types.go @@ -33,11 +33,6 @@ type LVMVolumeGroupSpec struct { // +optional NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"` - // TODO: add support for various LVM settings - // // Config for this deviceClass, lvm settings are a field here - // // +optional - // Config *DeviceClassConfig `json:"config,omitempty"` - // ThinPoolConfig contains configurations for the thin-pool // +kubebuilder:validation:Required // +required From 00eb8844b2a9d0fe864c312ca4dc9c9fa6cbdb8c Mon Sep 17 00:00:00 2001 From: Chad Scribner Date: Fri, 26 May 2023 15:00:22 -0400 Subject: [PATCH 3/5] cleanup: remove lvmcluseter_controller todo Covered by https://issues.redhat.com/browse/OCPVE-348 --- controllers/lvmcluster_controller.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/controllers/lvmcluster_controller.go b/controllers/lvmcluster_controller.go index 9e87f3124..fed82a5e9 100644 --- a/controllers/lvmcluster_controller.go +++ b/controllers/lvmcluster_controller.go @@ -96,10 +96,6 @@ type LVMClusterReconciler struct { // Reconcile is part of the main kubernetes reconciliation loop which aims to // move the current state of the cluster closer to the desired state. -// TODO(user): Modify the Reconcile function to compare the state specified by -// the LVMCluster object against the actual cluster state, and then -// perform operations to make the cluster state reflect the state specified by -// the user. // // For more details, check Reconcile and its Result here: // - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.10.0/pkg/reconcile From a249d19541240e4fdb73181e859ac203f979d2d6 Mon Sep 17 00:00:00 2001 From: Chad Scribner Date: Fri, 26 May 2023 15:03:51 -0400 Subject: [PATCH 4/5] cleanup: remove topolvm_controller todo Covered by https://issues.redhat.com/browse/OCPVE-363 --- controllers/topolvm_controller.go | 1 - 1 file changed, 1 deletion(-) diff --git a/controllers/topolvm_controller.go b/controllers/topolvm_controller.go index 82e5f528d..17ed83114 100644 --- a/controllers/topolvm_controller.go +++ b/controllers/topolvm_controller.go @@ -126,7 +126,6 @@ func getControllerDeployment(lvmCluster *lvmv1alpha1.LVMCluster, namespace strin {Name: "certs", VolumeSource: corev1.VolumeSource{EmptyDir: &corev1.EmptyDirVolumeSource{}}}, } - // TODO: Remove custom generation of TLS certs, current it's being used in topolvm controller manager initContainers := []corev1.Container{ initContainer(initImage), } From 7f961430962f6509e27c1c4b44679fde9423d528 Mon Sep 17 00:00:00 2001 From: Chad Scribner Date: Fri, 26 May 2023 15:39:53 -0400 Subject: [PATCH 5/5] cleanup: remove lvm todo Captured in https://issues.redhat.com/browse/OCPVE-364 --- pkg/vgmanager/lvm.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/vgmanager/lvm.go b/pkg/vgmanager/lvm.go index 66991c968..5d998196c 100644 --- a/pkg/vgmanager/lvm.go +++ b/pkg/vgmanager/lvm.go @@ -152,7 +152,6 @@ func (vg VolumeGroup) Delete(exec internal.Executor) error { func GetVolumeGroup(exec internal.Executor, name string) (*VolumeGroup, error) { res := new(vgsOutput) - // TODO: Check if `vgs --reportformat json` can be used to filter out the exact volume group name. args := []string{ "vgs", "--units", "g", "--reportformat", "json", }