Custom router certificate is not copied even if it's specified

[aerialls]

Description

Hello,

I think #4693 broke the behavior when you have a custom certificate declared for the hosted router.

In my ansible configuration, I've the following configuration for my internal certificate.

openshift_hosted_router_certificate={"certfile": "/root/certificates/wildcard.foobar.com.crt", "keyfile": "/root/certificates/wildcard.foobar.com.key", "cafile": "/root/certificates/internal-ca.crt"}

In the execution, the copy task is skipped.

TASK [openshift_hosted : Get the certificate contents for router] ***************************************************************************************
skipping: [node01.foobar.com] => (item=/root/certificates/wildcard.foobar.com.key)
skipping: [node01.foobar.com] => (item=/root/certificates/wildcard.foobar.com.crt)
skipping: [node01.foobar.com] => (item=/root/certificates/internal-ca.crt)

After some digging in this repo, The PR #4693 changed the default value for openshift_hosted_router_create_certificate from false to true. After that, the condition for the Get the certificate contents for router is now

  when: not openshift_hosted_router_create_certificate | bool

https://github.com/openshift/openshift-ansible/blob/release-3.6/roles/openshift_hosted/tasks/router/router.yml#L49

The generate a default wildcard router certificate task is also skipped because the openshift_hosted_router_certificate is not empty so I don't have any certificate and the Create OpenShift router task failed after that.

I can manually set the openshift_hosted_router_create_certificate parameter to false but I found no reference to this parameter in the documentation or elsewhere.

IMO, files should be copied if the parameter openshift_hosted_router_certificate is not empty regardless of the value of the openshift_hosted_router_create_certificate?

Version

!# ansible --version
ansible 2.3.1.0

!# git describe
openshift-ansible-3.6.173.0.7-1-4-ga74df94

[aerialls]

I tried to open a PR to fix this issue with my understanding. 😄