Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reflector.Run carry #15266

Closed
deads2k opened this issue Jul 18, 2017 · 2 comments
Closed

remove reflector.Run carry #15266

deads2k opened this issue Jul 18, 2017 · 2 comments
Assignees
@deads2k
Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P1
Milestone
v3.7

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

We have a carry commit to keep an old reflector.Run method. We need to sweep all the code and remove uses and plumb stopchannels through.
@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k self-assigned this Jul 18, 2017
@deads2k deads2k changed the title remove reflect.Run carry remove reflector.Run carry Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
Closed
56 tasks
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2018
@liggitt liggitt closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P1
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
4 participants
@liggitt @openshift-bot @deads2k @openshift-ci-robot