Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sdn's GetNodeCondition #15283

Closed
deads2k opened this issue Jul 18, 2017 · 4 comments
Closed

remove sdn's GetNodeCondition #15283

deads2k opened this issue Jul 18, 2017 · 4 comments
Assignees
Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Milestone

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

The rebase (#15234) had to make a copy of GetNodeCondition in pkg/sdn/plugin/subnets.go. The upstream function works against the external version. We should switch to using the external version to match.

@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
56 tasks
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2018
@danwinship
Copy link
Contributor

@pravisankar I think I remember seeing this function get killed off or rewritten in one of your active PRs? (pkg/network/master/subnets.go:GetNodeCondition())

@pravisankar
Copy link

Yes, this was fixed by #18758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Projects
None yet
Development

No branches or pull requests

6 participants