Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make upstream logrus match our #15295

Closed
deads2k opened this issue Jul 18, 2017 · 5 comments
Closed

make upstream logrus match our #15295

deads2k opened this issue Jul 18, 2017 · 5 comments
Assignees
@mfojtik
Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P1
Milestone
v3.7

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

github.com/Sirupsen/logrus needs to match between our levels.
@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
Closed
56 tasks
@mfojtik
Copy link
Contributor

mfojtik commented Jul 19, 2017

@deads2k you saying upstream logrus is behind our logrus?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 19, 2017

@deads2k you saying upstream logrus is behind our logrus?

It appeared that way during the rebase.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2018
@liggitt
Copy link
Contributor

liggitt commented Apr 11, 2018

we now match

@liggitt liggitt closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfojtik mfojtik

Labels
kind/post-rebase lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P1
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
5 participants
@mfojtik @liggitt @openshift-bot @deads2k @openshift-ci-robot