Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrintSuccess should be used through the cmdutil.Factory #17767

Closed
juanvallejo opened this issue Dec 13, 2017 · 2 comments
Closed

PrintSuccess should be used through the cmdutil.Factory #17767

juanvallejo opened this issue Dec 13, 2017 · 2 comments
Assignees
@juanvallejo
Labels
component/cli kind/post-rebase lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P1
Milestone
v3.9

Comments

@juanvallejo
Copy link
Contributor

The cmdutil.PrintSuccess helper was moved to be a method in the cmdutil.Factory (factory_builder.go)
A copy of this helper was created during the rebase in order to be able to use it in places where a cmdutil.Factory is not passed through. This needs to be fixed
@juanvallejo juanvallejo self-assigned this Dec 13, 2017
@deads2k deads2k mentioned this issue Dec 13, 2017
Merged
25 tasks
@mfojtik mfojtik added this to the 3.9.0 milestone Dec 14, 2017
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2018
@juanvallejo
Copy link
Contributor Author

Ongoing printer refactor will address this - we're moving away from having printer bits in the factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanvallejo juanvallejo

Labels
component/cli kind/post-rebase lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P1
Projects
None yet
Milestone
v3.9
Development

No branches or pull requests
4 participants
@mfojtik @openshift-bot @juanvallejo @openshift-ci-robot