Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestServerRunWithSNI failure #20220

Closed
bparees opened this issue Jul 5, 2018 · 3 comments
Closed

TestServerRunWithSNI failure #20220

bparees opened this issue Jul 5, 2018 · 3 comments
Assignees
@sttts
Labels
kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/master

Comments

@bparees
Copy link
Contributor

bparees commented Jul 5, 2018 

=== RUN   TestServerRunWithSNI
coverage: 27.4% of statements
panic: test timed out after 2m0s

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20064/pull-ci-origin-unit/846/

@openshift/sig-master
@bparees bparees added priority/P1 kind/test-flake Categorizes issue or PR as related to test flakes. labels Jul 5, 2018
@soltysh soltysh assigned sttts and unassigned mfojtik Jul 6, 2018
@sttts
Copy link
Contributor

sttts commented Jul 6, 2018

kubernetes/kubernetes#65899 might be the cure.

@smarterclayton smarterclayton mentioned this issue Jul 10, 2018
Merged
@smarterclayton
Copy link
Contributor

I separated out the test to make it clearer why it would fail in 66008, which shouldn't block your change.

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Jul 11, 2018
Merge pull request #66008 from smarterclayton/serving_test
ff9a66b 
Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Convert TestServerRunWithSNI to subtests to isolate flake

This test is flaking - make it easier to pin down where and why by
converting to subtests and making cleanup logic simpler. Also turn an
ignored listen error into a "fatal".

Make the test run in parallel to speed up individual runs and hopefully
flush out issues.

Noticed and reported in OpenShift, openshift/origin#20220

@deads2k / @sttts
k8s-publishing-bot added a commit to kubernetes/apiserver that referenced this issue Jul 11, 2018
@k8s-publishing-bot
Merge pull request #66008 from smarterclayton/serving_test
b7a5450 
Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Convert TestServerRunWithSNI to subtests to isolate flake

This test is flaking - make it easier to pin down where and why by
converting to subtests and making cleanup logic simpler. Also turn an
ignored listen error into a "fatal".

Make the test run in parallel to speed up individual runs and hopefully
flush out issues.

Noticed and reported in OpenShift, openshift/origin#20220

@deads2k / @sttts

Kubernetes-commit: ff9a66bd176c0e0ad992fd3496cc2b4b2a144f15
@sttts
Copy link
Contributor

sttts commented Jul 18, 2018

With #20309 merged 5 days ago, this should be fixed. @bparees please report back if we see the flake again.

Optimistically closing.

@sttts sttts closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sttts sttts

Labels
kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mfojtik @sttts @smarterclayton @bparees @openshift-ci-robot