Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable liveness probe in registry deployment config #5116

Closed
ncdc opened this issue Oct 14, 2015 · 6 comments
Closed

Reenable liveness probe in registry deployment config #5116

ncdc opened this issue Oct 14, 2015 · 6 comments

Comments

@ncdc
Copy link
Contributor

ncdc commented Oct 14, 2015

Now that we're no longer trying to support the v1 registry, we should be able to reenable the liveness probe that oadm registry adds to the registry's DC:

// TODO reenable the liveness probe when we no longer support the v1 registry.
/*
LivenessProbe: &kapi.Probe{
InitialDelaySeconds: 3,
TimeoutSeconds: 5,
Handler: kapi.Handler{
HTTPGet: &kapi.HTTPGetAction{
Path: "/healthz",
Port: util.NewIntOrStringFromInt(5000),
},
},
},
*/

@smarterclayton @mfojtik @miminar @pweil-

@pweil-
Copy link
Contributor

pweil- commented Oct 14, 2015

👍

@ncdc
Copy link
Contributor Author

ncdc commented Oct 14, 2015

I believe the upstream registry has updated their code so GET / should return a 200 instead of a 404. I'm not sure if that's in 2.0.1 (which we're based on) or 2.1.x. We should eventually be able to deprecate and remove our custom /healthz handler, but not right now.

@mfojtik
Copy link
Contributor

mfojtik commented Oct 14, 2015

+1

@miminar
Copy link

miminar commented Nov 16, 2015

Blocked on #4339.

@miminar
Copy link

miminar commented Dec 21, 2015

Resolved by #5404.

GET / is used now being used in liveness probe.

@miminar
Copy link

miminar commented Jan 25, 2016

@pweil- please close this. #5404 got merged.

@pweil- pweil- closed this as completed Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants