Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os::cmd::try_until_success doesn't correctly diagnose a failure due to timeout #6368

Closed
stevekuznetsov opened this issue Dec 17, 2015 · 0 comments · Fixed by #6371
Closed

os::cmd::try_until_success doesn't correctly diagnose a failure due to timeout #6368

stevekuznetsov opened this issue Dec 17, 2015 · 0 comments · Fixed by #6371
Assignees
@stevekuznetsov
Labels
area/tests kind/bug Categorizes issue or PR as related to a bug.

Comments

@stevekuznetsov
Copy link
Contributor

as seen on this issue: #6259, the stated reason for failure is that the wrong error code was returned, but in fact it is the timeout

@deads2k please assign to me
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevekuznetsov stevekuznetsov

Labels
area/tests kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

diagnose timeouts correctly in error message stevekuznetsov/origin
2 participants
@liggitt @stevekuznetsov