Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 crash picks + 1 carry #10541

Merged
merged 10 commits into from
Aug 19, 2016

Conversation

derekwaynecarr
Copy link
Member

Supersedes: #10526

Adds a carry for 29743 to preserve HandleCrash behaviors

Andy Goldstein and others added 10 commits August 18, 2016 22:13
Protect access of the original writer. Panics if anything has wrote
into the original writer or the writer is hijacked when times out.
The Pop method should allow a caller to requeue an item while under the
fifo lock, to avoid races on deletes.
…ed as read-only.

Send a node event when this happens and hint to the administrator
about the remediation.
Previously it was trying to use a nil pod variable if error was returned
from the pod update call.

(note that the rest of 26680 is unit test related, and not picked here)
@derekwaynecarr
Copy link
Member Author

[test]

@derekwaynecarr
Copy link
Member Author

@derekwaynecarr derekwaynecarr mentioned this pull request Aug 19, 2016
@derekwaynecarr
Copy link
Member Author

re[test]

@derekwaynecarr
Copy link
Member Author

The panics no longer exist in the system, testing again to see for flake.

@derekwaynecarr
Copy link
Member Author

re[test] due to flake #10546

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to bc075c8

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8269/)

@derekwaynecarr
Copy link
Member Author

marking [merge] per @eparis direction to allow earlier test.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 19, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8269/) (Image: devenv-rhel7_4883)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to bc075c8

@openshift-bot openshift-bot merged commit 2be9223 into openshift:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants