Deprecate OPENSHIFT_DEFAULT_REGISTRY environment variable #20150
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
| // OPENSHIFT_DEFAULT_REGISTRY environment variable which should be deprecated in | ||
| // future. | ||
| func DefaultRegistryHostnameRetriever(deprecatedDefaultRegistryEnvFn func() (string, bool), external, internal string) RegistryHostnameRetriever { | ||
| func DefaultRegistryHostnameRetriever(external, internal string) RegistryHostnameRetriever { |
There was a problem hiding this comment.
I don't see any value to this anymore. Why not just pass the two names around?
|
this isn't a deprecation, this is a removal.... |
|
We need to make sure the online teams are aware of this as i'm pretty sure they've used the env variable because the master-config setting did not appear to be working for them. |
|
In general i'm concerned about the impact on existing clusters where admins may have set the env variable a long time ago and never looked back. How confident are we that those clusters have any, or the same, value in their master-config? |
|
In 3.9 there's a step to set OPENSHIFT_DEFAULT_REGISTRY env var on the registry DC and the apiserver and controller env vars. Then we set imagePolicyConfig.internalRegistryHostname=docker-registry.default.svc:5000 in the 3.10 install and upgrade. We don't do anything to remove the env vars from the DC or apiserver and controllers in 3.10 upgrade. I think the only thing we'd want to do is remove the environment variables to avoid confusion in 3.11? |
we wouldn't need it on the apiserver+controller, but i think we still want the env var on the registry DC, unless we are injecting it into the registry config as described here: https://docs.openshift.org/latest/install_config/registry/extended_registry_configuration.html#docker-registry-configuration-reference-openshift also the preferred env var for the registry is now REGISTRY_OPENSHIFT_SERVER_ADDR, as covered here: https://docs.openshift.org/latest/install_config/registry/extended_registry_configuration.html#setting-the-registry-hostname |
|
@mfojtik: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
|
/test cross |
|
/retest |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
|
@mfojtik: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In 3.11 we should drop this variable in favor of master config configuration field that sets this up.
/cc @bparees
/cc @deads2k
Will follow up with deprecation notice in 3.11 release notes.