Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to kube 1.19-rc.2 #25314

Merged
merged 8 commits into from
Jul 30, 2020
Merged

Bump to kube 1.19-rc.2 #25314

merged 8 commits into from
Jul 30, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 23, 2020 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jul 23, 2020
@marun marun mentioned this pull request Jul 23, 2020
Merged
@sttts
Copy link
Contributor

sttts commented Jul 23, 2020

This will fail on #25308.

@marun marun force-pushed the bump-1.19.0-rc.2 branch from 62275a8 to e734578 Compare July 23, 2020 20:30
@sttts
Copy link
Contributor

sttts commented Jul 24, 2020 •
edited
Loading

The test results here are not relevant because they must run against 1.19 kube.

cluster-bot test runs of this PR and openshift/kubernetes#166:

Command: test <job> openshift/origin#25314,openshift/kubernetes#166

@sttts
Copy link
Contributor

sttts commented Jul 24, 2020

/retitle Prebase bump to kube 1.19-rc.2

@openshift-ci-robot openshift-ci-robot changed the title WIP FAKE bump(*) to kube 1.19-rc.2 Rebase bump to kube 1.19-rc.2 Jul 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2020
@openshift-ci-robot openshift-ci-robot changed the title Rebase bump to kube 1.19-rc.2 Prebase bump to kube 1.19-rc.2 Jul 24, 2020
@eparis
Copy link
Member

eparis commented Jul 25, 2020

/retest

2 similar comments
@mfojtik
Copy link
Contributor

mfojtik commented Jul 27, 2020

/retest

@cynepco3hahue
Copy link
Contributor

/retest

@damemi
Copy link

damemi commented Jul 27, 2020

Pr to skip the failing Kubectl client Simple pod should return command exit codes test is here: #25322

@damemi
Copy link

damemi commented Jul 27, 2020

/retest

@marun marun force-pushed the bump-1.19.0-rc.2 branch from bd6eb30 to bec8dec Compare July 28, 2020 05:53
@marun
Copy link
Contributor Author

marun commented Jul 28, 2020

Pr to skip the failing Kubectl client Simple pod should return command exit codes test is here: #25322

I've included the skip in this PR to speed up testing: cbab573#diff-6ba77494282f6e840f44b01ce97335af

@marun marun force-pushed the bump-1.19.0-rc.2 branch from bec8dec to ab2db76 Compare July 28, 2020 06:07
@marun
Copy link
Contributor Author

marun commented Jul 28, 2020

@sttts I've added the etcd-storage-path fix and skipped everything that was discussed as being skippable (with bz's as appropriate).

I also reviewed the alpha feature gates in rules.go to make it obvious which are perpetual skips (e.g. gpu), which are alpha this release and should be reviewed next release, and which are beta this release and need to be enabled by the relevant teams in 4.6 (with tracking bz's to ensure it gets done).

@sttts
Copy link
Contributor

sttts commented Jul 28, 2020

go.sum content is incorrect - did you run go mod tidy?

@deads2k
Copy link
Contributor

deads2k commented Jul 28, 2020 •
edited
Loading

/retest

for more signal

@marun marun force-pushed the bump-1.19.0-rc.2 branch from ab2db76 to 3d197ed Compare July 28, 2020 16:30
@marun
Copy link
Contributor Author

marun commented Jul 28, 2020

go.sum content is incorrect - did you run go mod tidy?

🤦 updated

@sjenning sjenning mentioned this pull request Jul 28, 2020
Merged
@marun marun force-pushed the bump-1.19.0-rc.2 branch from 3d197ed to 827c70e Compare July 28, 2020 21:04
@marun
Copy link
Contributor Author

marun commented Jul 28, 2020

/retest

This was referenced Jul 28, 2020
Merged
Merged
@marun
Copy link
Contributor Author

marun commented Jul 29, 2020

/retest

1 similar comment
@deads2k
Copy link
Contributor

deads2k commented Jul 29, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 29, 2020

The gcp-upgrade failures are persistent:

  • [sig-arch][Feature:ClusterUpgrade] Cluster should remain functional during upgrade [Disruptive] [Serial] [Suite:openshift] 
  • [sig-network-edge] Application behind service load balancer with PDB is not disrupted

@marun
Copy link
Contributor Author

marun commented Jul 30, 2020

/retest

marun added 3 commits July 29, 2020 20:29
@marun
Update rules.go skips for 1.19
27bee84 
In addition to new skips, the following skips have been removed

- VolumeSubpathEnvExpansion feature has gone GA and the feature gate
removed in 1.19.

- DynamicAudit feature was removed in 1.17

- Feature:StatefulUpgrade is no longer present

- Feature:ManualPerformance is no longer present

- Feature:HighDensityPerformance is no longer present

- `should ensure that critical pod is scheduled in case there is no
resources available` is no longer present

- `authentication: OpenLDAP` is no longer present
@marun
make update
2158ffd
@marun
Temporarily skip service upgrade test broken by 1.19 rebase
35927ea
@marun marun force-pushed the bump-1.19.0-rc.2 branch from 2988913 to 35927ea Compare July 30, 2020 03:30
@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/test e2e-gcp

@openshift-ci-robot
Copy link

@sttts: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-cm

Only the following contexts were expected:

  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-cmd
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-builds
  • ci/prow/e2e-gcp-image-ecosystem
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/images
  • ci/prow/verify
  • ci/prow/verify-deps
  • tide

In response to this:

/override ci/prow/e2e-cm

Still broken. @soltysh is working on fixing it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/override ci/prow/e2e-cmd

Still broken. @soltysh is working on fixing it.

@openshift-ci-robot
Copy link

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-cmd

In response to this:

/override ci/prow/e2e-cmd

Still broken. @soltysh is working on fixing it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/test e2e-aws-serial

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/title Bump to kube 1.19-rc.2

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

Look like random flake.

/test e2e-aws-serial

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/retitle Bump to kube 1.19-rc.2

@openshift-ci-robot openshift-ci-robot changed the title Prebase bump to kube 1.19-rc.2 Bump to kube 1.19-rc.2 Jul 30, 2020
@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

Install flake, PR history looks different. Moreover, this PR does not change the installer.

/test e2e-gcp

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/test e2e-aws-fips

@bparees bparees merged commit 1261678 into openshift:master Jul 30, 2020
@bparees
Copy link
Contributor

bparees commented Jul 30, 2020

manually merged after review of passing tests in test history and discussion with @sttts and @marun

frobware added a commit to frobware/origin that referenced this pull request Jul 31, 2020
@frobware
Bug 1861944: re-enable service upgrade
b8ad647 
This was disabled in:

  openshift#25314
@frobware frobware mentioned this pull request Jul 31, 2020
Closed
@joelsmith joelsmith mentioned this pull request Aug 4, 2020
Closed
aojea pushed a commit to aojea/origin that referenced this pull request Aug 12, 2020
@frobware
Bug 1861944: re-enable service upgrade
54e4908 
This was disabled in:

  openshift#25314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@marun @sttts @eparis @mfojtik @cynepco3hahue @damemi @deads2k @tnozicka @openshift-ci-robot @bparees