Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in Questionnaire pagination button styles #3212

Closed
LZRS opened this issue Apr 22, 2024 · 4 comments · Fixed by #3244
Closed

Difference in Questionnaire pagination button styles #3212

LZRS opened this issue Apr 22, 2024 · 4 comments · Fixed by #3244

Comments

@LZRS
Copy link
Contributor

LZRS commented Apr 22, 2024

Describe the bug
A paginated questionnaire when rendered, the "previous"/"next" button have distinctly different styling from that of the "submit" button

Expected behavior
The button should probably be similar styled or may be allowed to be configurable

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Samsung Galaxy A2 emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 24]

Additional context
Add any other context about the problem here.

@allan-on
Copy link
Contributor

allan-on commented Apr 30, 2024

Hello @rowo @HenryRae The Questionnaire submit buttons in OpenSRP appear to be differently shaped compared to the submit buttons in the Google SDK as seen in their demo apps.
When we have paginated Questionnaires, the previous/next and submit buttons have a different look
Is this by design? cc @pld

|

@HenryRae
Copy link

HenryRae commented May 3, 2024

Here's how forms were designed. Thus this what should be followed, however we are happy to adjust the designs to what we are able to archive technically.

@Gental-Giant
Copy link

Gental-Giant commented May 3, 2024

Thanks @HenryRae

@allan-on Is what we have from the design team achievable?

image

image

@LZRS
Copy link
Contributor Author

LZRS commented May 8, 2024

@HenryRae Would these suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants