Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyway to disable nagle algorythm from here? #41

Closed
Tierney0115 opened this issue Jan 12, 2016 · 4 comments
Closed

Is there anyway to disable nagle algorythm from here? #41

Tierney0115 opened this issue Jan 12, 2016 · 4 comments

Comments

@Tierney0115
Copy link

I found the remote debug latency is really big and I am trying to disable Nagle algo from both server and client side for STF. Thanks.

@sorccu
Copy link
Member

sorccu commented Jan 12, 2016

Hmm, looks like there's been a misunderstanding. The Node.js docs say:

Disables the Nagle algorithm. By default TCP connections use the Nagle algorithm, they buffer data before sending it off. Setting true for noDelay will immediately fire off data each time socket.write() is called. noDelay defaults to true.

Because it says "noDelay defaults to true", I thought that it was enabled by default, and that "By default TCP connections use the Nagle algorithm" is more of a generic statement about TCP connections.

Now that I've checked it again, it doesn't look like it's doing it by default after all. What it's really saying is that if you call .setNoDelay() without any arguments, the argument defaults to true. It's a simple change, I will push a new version later.

@sorccu
Copy link
Member

sorccu commented Jan 12, 2016

It probably depends on your internal network and machine settings, though, since we never had this issue.

@sorccu
Copy link
Member

sorccu commented Jan 12, 2016

I've released 2.4.0 with TCP_NODELAY. Please run npm update adbkit in your STF repo and report back whether the situation improved or not.

@Tierney0115
Copy link
Author

Disable Nagle fix my debugging problem. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants