Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write history in the middle of draw_line/draw_way, etc #3750

Closed
bhousel opened this issue Jan 12, 2017 · 1 comment
Closed

Don't write history in the middle of draw_line/draw_way, etc #3750

bhousel opened this issue Jan 12, 2017 · 1 comment
Assignees
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!

Comments

@bhousel
Copy link
Member

bhousel commented Jan 12, 2017

It turns out that it is really easy to create a lot of these degenerate geometries in iD that we've spent years trying to track down. (1-node ways, 2-node areas, etc)

  1. Start drawing a thing
  2. ⌘R Refresh your browser
  3. Restore history
  4. Partially drawn thing exists.. Oops! 😱

So we should really disable history writes while the user is in the process of drawing stuff.

@bhousel bhousel added the bug-release-blocker An important bug - let's get this fixed in the next release! label Jan 12, 2017
@bhousel bhousel self-assigned this Jan 12, 2017
@bhousel bhousel added the wip Work in progress label Jan 12, 2017
@bhousel bhousel removed the wip Work in progress label Feb 3, 2017
@tyrasd
Copy link
Member

tyrasd commented Feb 3, 2017

Excellent find, Bryan! :shipit: I almost can't believe it was something that "obvious".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!
Projects
None yet
Development

No branches or pull requests

2 participants