Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presets for theme park attractions #4236

Merged
merged 3 commits into from
Aug 18, 2017

Conversation

willemarcel
Copy link
Contributor

@willemarcel willemarcel commented Aug 17, 2017

},
"name": "Animal"
},
"attraction/big_wheel": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe height and/or Radius

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added height!

},
"attraction/bungee_jumping": {
"icon": "pitch",
"fields": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe height?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added! thanks @magol !

},
"attraction/roller_coaster": {
"icon": "amusement-park",
"fields": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also make sense to add fee onto these presets? Most parks charge per ride.

@bhousel
Copy link
Member

bhousel commented Aug 17, 2017

@willemarcel Can you please remove species? per #3600, I'd prefer for all the sidebar fields in iD to be only the kinds of things that an untrained mapper could fill in.

Everything else looks great, thanks! 👍

@willemarcel
Copy link
Contributor Author

@bhousel done!

@bhousel
Copy link
Member

bhousel commented Aug 18, 2017

Thanks @willemarcel this looks great!.. merging..

@bhousel bhousel merged commit d8fcff6 into openstreetmap:master Aug 18, 2017
@bhousel
Copy link
Member

bhousel commented Aug 18, 2017

BTW, if you are looking for another tag to do, you could do the same thing for playground equipment -
playground=*
https://wiki.openstreetmap.org/wiki/Key:playground

(Someone was asking about this one on reddit recently.)

# 'terms: theme park,bungy jumping,jumping platform'
terms: '<translate with synonyms or related terms for ''Bungee Jumping'', separated by commas>'
attraction/carousel:
# attraction=carousel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the tagging proposal is an attraction=swing_carousel tag for swing rides. That caught my attention because “swing ride” apparently has a well-known translation in Vietnamese, but ordinary horse carousels don’t have as obvious a translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants