Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mapping of footbridges #4309

Closed
GerdP opened this issue Sep 4, 2017 · 10 comments
Closed

Wrong mapping of footbridges #4309

GerdP opened this issue Sep 4, 2017 · 10 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@GerdP
Copy link

GerdP commented Sep 4, 2017

It seems that ID is somehow misleading mappers to use a way with highway=crossing + traffic_calming=table for a footbridge.
I've seen several places where different mappers have added new ways like this or changed
existing correct tagging. I am not familiar with ID, so I have no idea why.
See also https://forum.openstreetmap.org/viewtopic.php?id=59608

@JamesKingdom JamesKingdom added the preset An issue with an OpenStreetMap preset or tag label Sep 4, 2017
@JamesKingdom
Copy link
Collaborator

It seems to happen with Raised Pedestrian Crossing:

This should be used on highways to map a slightly raised section that is designated for pedestrians to cross, but the use case on w518945321, is incorrect. They have mistaken this for a bridge, but it is easy to see why, the name is pretty generic.
Maybe we should consider naming it differently.

@GerdP
Copy link
Author

GerdP commented Sep 4, 2017

The tag highway=crossing should only be used on nodes. The tag traffic_calming=table might be used on ways but I think it makes more sense when it is used on a node together with highway=crossing.

@bhousel
Copy link
Member

bhousel commented Sep 4, 2017

It looks like iD's use of the preset matches up with current use of the tag and documentation on the OSM wiki. If you find that users are confused, this is normal, and the right thing to do is send them a nice message on a changeset discussion to help them out, and to fix the tag according to how mapping is done in your part of the world.

@bhousel bhousel closed this as completed Sep 4, 2017
@GerdP
Copy link
Author

GerdP commented Sep 4, 2017

What tag do you mean? If ID encourages the user to use the tag highway=crossing on a way this is simply wrong.

@GerdP
Copy link
Author

GerdP commented Sep 4, 2017

Please check also this CS diskussion:
http://www.openstreetmap.org/changeset/51182181

@bhousel
Copy link
Member

bhousel commented Sep 5, 2017

What tag do you mean? If ID encourages the user to use the tag highway=crossing on a way this is simply wrong.

Oh I see now, sorry.. there is an issue in here: https://github.com/openstreetmap/iD/blob/master/data/presets/presets/traffic_calming/table.json#L17

We should probably just turn that into a single feature that's a combination of zebra crossing and traffic calming.

@bhousel bhousel reopened this Sep 5, 2017
@GerdP
Copy link
Author

GerdP commented Sep 5, 2017

My current understanding is that you can use trafifc_calming=table in two very different situations

  1. as a node that is shared by a highway=footway way and another highway=* way which describes a road used by 4 wheel vehicles. In this situation the node should always be tagged as highway=crossing,
    no matter if there is a traffic_calming
  2. On a way . I am not sure what it should describe in this case, but when I see a highway=* with traffic_calming=* I assume that there is at least one such traffic_calming on this part of the road.
    I would not encourage this usage with a preset.

So, I suggest to change the preset so that it is only used for nodes. If possible, only for nodes shared by a footway and another more important highway..

@GerdP
Copy link
Author

GerdP commented Sep 5, 2017

Sorry, I've just noted that I added another comment in the forum instead of here:
https://forum.openstreetmap.org/viewtopic.php?pid=662265#p662265

@bhousel bhousel closed this as completed in 21a090b Sep 8, 2017
@bhousel
Copy link
Member

bhousel commented Sep 8, 2017

I did the following:

  • Added presets for raised crossing and raised crosswalk, same as the existing
    crossing and crosswalk presets but with traffic_calming=table added
  • Retained a generic traffic_calming=table preset without crossing tags,
    and for usage on vertex geometry only (removed line, which caused the issue)

@GerdP
Copy link
Author

GerdP commented Sep 9, 2017

Thanks, I don't understand all changes, but what I understood looks promising ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants