Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"substance=" field to pipeline preset #4430

Closed
abdeldjalil09 opened this issue Oct 12, 2017 · 6 comments
Closed

"substance=" field to pipeline preset #4430

abdeldjalil09 opened this issue Oct 12, 2017 · 6 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Oct 12, 2017 •
edited by bhousel
Loading

https://wiki.openstreetmap.org/wiki/Key:substance
@bhousel
Copy link
Member

bhousel commented Oct 12, 2017 •
edited
Loading

Sounds good to me 👍

@TheGreenToaster - want to take care of this? Update: @xmile1 assigned
It would be similar to the steps you did for the trade shop in #4410..

  • git pull and npm install to update your local copy of the repo
  • copy a combo field like data/presets/fields/site.json to a new field data/presets/fields/substance.json, then change the "key" to say "substance" and the label to say "Substance"
  • add "substance" to the "fields" array in data/presets/presets/man_made/pipeline.json
  • npm run build to update the generated files

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest preset An issue with an OpenStreetMap preset or tag labels Oct 12, 2017
@xmile1
Copy link
Contributor

xmile1 commented Oct 12, 2017

Hi @bhousel, I am new to this project, If its okay for me to work on this let me know, I have my dev env setup.

@bhousel
Copy link
Member

bhousel commented Oct 12, 2017

Hi @bhousel, I am new to this project, If its okay for me to work on this let me know, I have my dev env setup.

Yes @xmile1 go ahead and work on it 👍 Thanks!

@xmile1
Copy link
Contributor

xmile1 commented Oct 12, 2017

so to be clear, following those highlighted step are what I need right?

@bhousel
Copy link
Member

bhousel commented Oct 12, 2017

so to be clear, following those highlighted step are what I need right?

Yes @xmile1 you got it... Check the README under data/presets if you want some more context, but it is really just adding one new .json file and editing another existing .json file.

@xmile1 xmile1 mentioned this issue Oct 12, 2017
Merged
@bhousel
Copy link
Member

bhousel commented Oct 13, 2017

closed in #4432

@bhousel bhousel closed this as completed Oct 13, 2017
@bhousel bhousel mentioned this issue Nov 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhousel @xmile1 @abdeldjalil09