Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery that wasn't actually used added to imagery_used list #4827

Closed
simonpoole opened this issue Feb 21, 2018 · 3 comments
Closed

Imagery that wasn't actually used added to imagery_used list #4827

simonpoole opened this issue Feb 21, 2018 · 3 comments
Labels
core An issue with one of the core iD components

Comments

@simonpoole
Copy link
Contributor

It is a minor nitpick: iD will always add the currently selected background layer to the imagery_used list even if the coverage area was never actually intersected by the edits (aka the imagery was never on the screen). This can be slightly confusing to somebody inspecting the changesets after the edits as the information would seem to make no sense (which is probably actually the case :-)).

@bhousel
Copy link
Member

bhousel commented Feb 21, 2018

Trying to understand this issue better. Is this like:

  1. user selects a local (not global) imagery source
  2. user pans map somewhere else where that imagery is not available
  3. user edits something (presumably the background imagery is blank here)

What should iD do in this situation?

@bhousel bhousel added the core An issue with one of the core iD components label Feb 21, 2018
@simonpoole
Copy link
Contributor Author

Yes (situation description).

what should iD do: add nothing to the list IMHO (to be on the save side ai would only add nothing if the current screen bounding box doesn't intersect with the imagery at all.

As said it is a minor nitpick nothing anybody is going to get upset about.

@bhousel
Copy link
Member

bhousel commented Feb 21, 2018

Thanks for the clarification - I agree iD's imagery used code could be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core An issue with one of the core iD components
Projects
None yet
Development

No branches or pull requests

2 participants