From 92d4f7b40d7e3bb4b6e91236cf32b399a690bab3 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 12:28:33 +0000 Subject: [PATCH 01/13] ci: pull request template --- .github/pull_request_template.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..44105e5e6 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,28 @@ +## ✨ Context + + + +## 🛠 What does this PR implement + + + +## 🙈 Missing + + + +## 🚦 Checks + +- [ ] covers one single feature (one change at a time) +- [ ] documentation added/updated +- [ ] there is no commented out code in this PR +- [ ] follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in PR title and commits. +- [ ] is up-to-date with `dev` branch +- [ ] tests have been added to verify that the new code works +- [ ] passes local tests (`make test`) +- [ ] passes pre-commits (e.g `poetry run pre-commit run --all-files`) From bdbd6434d360adabfc92a187e0bde6858044b412 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:16:44 +0000 Subject: [PATCH 02/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 44105e5e6..d7c970eeb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,7 +16,7 @@ add diagrams or images if necessary. It'll help the reviewer_ --> -## 🚦 Checks +## 🚦 Before submitting - [ ] covers one single feature (one change at a time) - [ ] documentation added/updated From d0b7731cf612a1d7b0f309489bd593cdca0f9c7c Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:34:56 +0000 Subject: [PATCH 03/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d7c970eeb..665f53602 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,6 @@ ## ✨ Context - ## 🚦 Before submitting -- [ ] covers one single feature (one change at a time) +- [ ] Do these changes cover one single feature (one change at a time)? - [ ] documentation added/updated - [ ] there is no commented out code in this PR - [ ] follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in PR title and commits. From 6a43f1a82d988fd6de39de8c1d87640a32a23b88 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:40:52 +0000 Subject: [PATCH 05/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fb85d0173..4c5ccedee 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,7 +19,8 @@ add diagrams or images if necessary. It'll help the reviewer_ --> ## 🚦 Before submitting - [ ] Do these changes cover one single feature (one change at a time)? -- [ ] documentation added/updated +- [ ] Did you read the [contributor guideline](https://opentargets.github.io/gentropy/development/contributing/#contributing-checklist)? +- [ ] Did you make sure to update the documentation with your changes? - [ ] there is no commented out code in this PR - [ ] follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in PR title and commits. - [ ] is up-to-date with `dev` branch From 14e70971cf7327410d95ead883afefde80d22f60 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:41:11 +0000 Subject: [PATCH 06/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4c5ccedee..32eb99bf9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -21,7 +21,7 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Do these changes cover one single feature (one change at a time)? - [ ] Did you read the [contributor guideline](https://opentargets.github.io/gentropy/development/contributing/#contributing-checklist)? - [ ] Did you make sure to update the documentation with your changes? -- [ ] there is no commented out code in this PR +- [ ] Did you make sure there is no commented out code in this PR? - [ ] follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in PR title and commits. - [ ] is up-to-date with `dev` branch - [ ] tests have been added to verify that the new code works From d4988fe8bbcbf9bf5fa0017c849e4b57a213b724 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:41:31 +0000 Subject: [PATCH 07/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 32eb99bf9..2f9949b99 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,7 +22,7 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Did you read the [contributor guideline](https://opentargets.github.io/gentropy/development/contributing/#contributing-checklist)? - [ ] Did you make sure to update the documentation with your changes? - [ ] Did you make sure there is no commented out code in this PR? -- [ ] follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in PR title and commits. +- [ ] Did you follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standards in PR title and commit messages? - [ ] is up-to-date with `dev` branch - [ ] tests have been added to verify that the new code works - [ ] passes local tests (`make test`) From d0aa31375a17e19ba263f396b08feb0cbdc61936 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:41:43 +0000 Subject: [PATCH 08/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2f9949b99..a95f3c700 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -23,7 +23,7 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Did you make sure to update the documentation with your changes? - [ ] Did you make sure there is no commented out code in this PR? - [ ] Did you follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standards in PR title and commit messages? -- [ ] is up-to-date with `dev` branch +- [ ] Did you make sure the branch is up-to-date with the `dev` branch? - [ ] tests have been added to verify that the new code works - [ ] passes local tests (`make test`) - [ ] passes pre-commits (e.g `poetry run pre-commit run --all-files`) From 170289973b252a27fce35ba6e1c3948ab0ef37f7 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:41:44 +0000 Subject: [PATCH 09/13] chore: pre-commit auto fixes [...] --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a95f3c700..594856bd0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,7 +20,7 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Do these changes cover one single feature (one change at a time)? - [ ] Did you read the [contributor guideline](https://opentargets.github.io/gentropy/development/contributing/#contributing-checklist)? -- [ ] Did you make sure to update the documentation with your changes? +- [ ] Did you make sure to update the documentation with your changes? - [ ] Did you make sure there is no commented out code in this PR? - [ ] Did you follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standards in PR title and commit messages? - [ ] Did you make sure the branch is up-to-date with the `dev` branch? From 8b8c25d516107a429e23a5a38c3a2037ec59cf1c Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:42:05 +0000 Subject: [PATCH 10/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 594856bd0..fb2a2ef0d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -24,6 +24,6 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Did you make sure there is no commented out code in this PR? - [ ] Did you follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standards in PR title and commit messages? - [ ] Did you make sure the branch is up-to-date with the `dev` branch? -- [ ] tests have been added to verify that the new code works +- [ ] Did you write any new necessary tests? - [ ] passes local tests (`make test`) - [ ] passes pre-commits (e.g `poetry run pre-commit run --all-files`) From 38f350cf96f32a1e99c523a6c92ab80568b202eb Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:42:15 +0000 Subject: [PATCH 11/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fb2a2ef0d..82a7b7d43 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -25,5 +25,5 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Did you follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standards in PR title and commit messages? - [ ] Did you make sure the branch is up-to-date with the `dev` branch? - [ ] Did you write any new necessary tests? -- [ ] passes local tests (`make test`) +- [ ] Did you make sure the changes pass local tests (`make test`)? - [ ] passes pre-commits (e.g `poetry run pre-commit run --all-files`) From b5b2699c5eefbcf4f84d997912ecb7386de939e7 Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:42:24 +0000 Subject: [PATCH 12/13] Update .github/pull_request_template.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 82a7b7d43..0f6349b42 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -26,4 +26,4 @@ add diagrams or images if necessary. It'll help the reviewer_ --> - [ ] Did you make sure the branch is up-to-date with the `dev` branch? - [ ] Did you write any new necessary tests? - [ ] Did you make sure the changes pass local tests (`make test`)? -- [ ] passes pre-commits (e.g `poetry run pre-commit run --all-files`) +- [ ] Did you make sure the changes pass pre-commit rules (e.g `poetry run pre-commit run --all-files`)? From 730ed73957a9f14790a5fdcf85fef2a856838aaa Mon Sep 17 00:00:00 2001 From: David Ochoa Date: Mon, 4 Mar 2024 15:46:18 +0000 Subject: [PATCH 13/13] refactor: il-suggestion --- .github/pull_request_template.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0f6349b42..aca51c6ea 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,9 @@ ## ✨ Context - ## 🛠 What does this PR implement