[Bug]: New Vocations

[tuliovgomes]

What happened?

• Create new promotions for the base vocations of the server and when I promote the player the server simply breaks.
• The changes that i made: in data/lib/core/functions/player I changed all these functions adding a new promotions Ex:

function Player.isSorcerer(self)
	return table.contains({
		VOCATION.ID.SORCERER,
		VOCATION.ID.MASTER_SORCERER,
		VOCATION.ID.ARCHMAGE,
		VOCATION.ID.ARCANE_WIZARD,
		VOCATION.ID.DIVINE_MAGE
	}, self:getVocation():getId())
end

in data/lib/table/vocations

VOCATION = {
	ID = {
		NONE = 0,
		SORCERER = 1,
		DRUID = 2,
		PALADIN = 3,
		KNIGHT = 4,

		MASTER_SORCERER = 5,
		ELDER_DRUID = 6,
		ROYAL_PALADIN = 7,
		ELITE_KNIGHT = 8,

		ARCHMAGE = 9,
		CELTIC_DRUID = 10,
		MEDIEVAL_CROSSBOWMAN = 11,
		TEMPLAR_KNIGHT = 12,
	},
	CLIENT_ID = {
		NONE = 0,
		KNIGHT = 1,
		PALADIN = 2,
		SORCERER = 3,
		DRUID = 4,

		ELITE_KNIGHT = 11,
		ROYAL_PALADIN = 12,
		MASTER_SORCERER = 13,
		ELDER_DRUID = 14,

		ARCHMAGE = 17,
		CELTIC_DRUID = 18,
		MEDIEVAL_CROSSBOWMAN = 16,
		TEMPLAR_KNIGHT = 15,
	},
	BASE_ID = {
        NONE = 0,
        SORCERER = 1,
        DRUID = 2,
        PALADIN = 3,
        KNIGHT = 4
	}
}

when player get a new promotion promotion the server down, and of course I created the vocation in the vocation.xml file, is there somewhere else i need to change?

How to Reproduce?

1 - create a new promotion of vocation
2 - alter the files
3 - get promotion and the problem happens

Relevant log output

• 3221225477

Attach any relevant file

No response

Version

12.x (Default)

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[beats-dh]

I don't remember the place but all the vocations in the vocation.xml have to be in a src file too. Search src for existing vocations

[beats-dh]

I will close this issue because this is not a problem

[tuliovgomes]

@beats-dh I did what you said I changed the src, compiled it again but it's still buggy, u can reopen ?

[beats-dh]

@beats-dh I did what you said I changed the src, compiled it again but it's still buggy, u can reopen ?

Use this commit as an example for you to do in yours! beats-dh@f5c02ef

[tuliovgomes]

@beats-dh i think the problem is the clientId, i just repeat the base vocation clientId in new vocation and it worked, tks
your commit made me see this...