[Bug]: current canary/otservbr-global master branches crash server on attacking monster

[ghost]

What happened?

current canary/otservbr-global master branches crash server on attacking monster

How to Reproduce?

attack any monster

Relevant log output

2022-03-22 20:23:12 -  scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/others/boss_reward_chest.lua:callback]
2022-03-22 20:23:12 -  timerEvent: []
2022-03-22 20:23:12 -   callbackId:[]
2022-03-22 20:23:12 -  function: [Scripts Interface]
2022-03-22 20:23:12 -  error [Creature not found
2022-03-22 20:23:12 -  stack traceback:] 
2022-03-22 20:23:12 -  [2022-22-03 20:23:12.032] [error] Lua script error: 
2022-03-22 20:23:12 -  scriptInterface: [Scripts Interface]
2022-03-22 20:23:12 -  scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/leiden_heal.lua:callback]
2022-03-22 20:23:12 -  timerEvent: []
2022-03-22 20:23:12 -   callbackId:[]
2022-03-22 20:23:12 -  function: [Scripts Interface]
2022-03-22 20:23:12 -  error [Creature not found
2022-03-22 20:23:12 -  stack traceback:] 
2022-03-22 20:23:12 -  [2022-22-03 20:23:12.032] [error] Lua script error: 
2022-03-22 20:23:12 -  scriptInterface: [Scripts Interface]
2022-03-22 20:23:12 -  scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/pillar_health.lua:callback]
2022-03-22 20:23:12 -  timerEvent: []
2022-03-22 20:23:12 -   callbackId:[]
2022-03-22 20:23:12 -  function: [Scripts Interface]
2022-03-22 20:23:12 -  error [Creature not found
2022-03-22 20:23:12 -  stack traceback:]

Attach any relevant file

No response

Version

12.x (Default)

What OS are you seeing the problem on?

Linux

Code of Conduct

• I agree to follow this project's Code of Conduct

[dudantas]

Try use this fix: b79a612

[dudantas]

Please come back with the answer if this commit fix it.

[ghost]

It's merged into master, I downloaded latest version master 2 hours ago and crash occurs

[dudantas]

In that case you need to give more details. How do we reproduce the crash? Just playing the log there doesn't help much!

[ghost]

it happens after attacking monster, I checked on 2 characters - one attacking sandcrawler, other one attacking earth elemental, both caused instant server crash

[dudantas]

No crash.

[ghost]

I'll check again, and update on more conditions

[ghost]

[2022-22-03 21:39:16.357] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/others/boss_reward_chest.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 
[2022-22-03 21:39:16.357] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/leiden_heal.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 
[2022-22-03 21:39:16.357] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/pillar_health.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 
Segmentation fault (core dumped)

Steps I did:
Logged into god, killed 2 earth elementals, nothing happened
Logged in into regular character, killed 4 sandcrawlers, nothing
Rolled for prey and chose random one
Killed 2 more earth elementals with regular character - crashed

[dudantas]

Can you get the crash log using debug?

[ghost]

Could you explain to me how to run it debug?

[omeranha]

Could you explain to me how to run it debug?

which weapon you used to attack the monster?

[ghost]

exori flam and wand of dragonbreath

[ghost]

debug log:

[2022-23-03 00:49:31.541] [file /home/ubuntu/server69/bagno_canary/src/lua/functions/lua_functions_loader.cpp:105] [func reportError] [thread 174348] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/others/boss_reward_chest.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 
[2022-23-03 00:49:31.541] [file /home/ubuntu/server69/bagno_canary/src/lua/functions/lua_functions_loader.cpp:105] [func reportError] [thread 174348] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/leiden_heal.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 
[2022-23-03 00:49:31.541] [file /home/ubuntu/server69/bagno_canary/src/lua/functions/lua_functions_loader.cpp:105] [func reportError] [thread 174348] [error] Lua script error: 
scriptInterface: [Scripts Interface]
scriptId: [/home/ubuntu/server69/bagno_live/data/scripts/creaturescripts/quests/cults_of_tibia/pillar_health.lua:callback]
timerEvent: []
 callbackId:[]
function: [Scripts Interface]
error [Creature not found
stack traceback:] 

Thread 2 "canary" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff79ce700 (LWP 174348)]

[ghost]

revert #278 fixed issue