Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OperationNameConstructor support to ServerTracingInterceptor #4

Open
Falco20019 opened this issue May 8, 2018 · 1 comment
Open

Improve OperationNameConstructor support to ServerTracingInterceptor #4

Falco20019 opened this issue May 8, 2018 · 1 comment
Assignees
@Falco20019
Labels
enhancement New feature or request

Comments

@Falco20019
Copy link
Collaborator

Falco20019 commented May 8, 2018 •
edited
Loading

Right now, GRPC Interceptors for C# don't have good support for name construction. While the ClientTracingInterceptor can use ClientInterceptorContext<TRequest, TResponse> to receive an Method<TRequest, TResponse> instance for the method, the ServerTracingInterceptor only offers ServerCallContext which has just a string instance for the method. IOperationNameConstructor therefore has two methods for both variants.

It would be great, if Google would resolve this asymmetry in grpc-csharp.
@Falco20019 Falco20019 added the enhancement New feature or request label May 8, 2018
@Falco20019
Copy link
Collaborator Author

Created issue grpc/grpc#15316 to resolve this.

@Falco20019 Falco20019 self-assigned this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Falco20019 Falco20019

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Falco20019