Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't send JMS messages, getting 'uber-trace-id' is not a valid java identifier. #234

Open
alextrs opened this issue Jul 29, 2019 · 2 comments · May be fixed by opentracing-contrib/java-spring-messaging#29
Open

Can't send JMS messages, getting 'uber-trace-id' is not a valid java identifier. #234

alextrs opened this issue Jul 29, 2019 · 2 comments · May be fixed by opentracing-contrib/java-spring-messaging#29

Comments

@alextrs
Copy link

alextrs commented Jul 29, 2019

Using spring-integration and after added the opentracing starter:

        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-jaeger-cloud-starter</artifactId>
            <version>1.0.3</version>
        </dependency>
        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-cloud-starter</artifactId>
            <version>0.2.4</version>
        </dependency>

started to get errors:

javax.jms.JMSRuntimeException: AMQ139012: The property name 'uber-trace-id' is not a valid java identifier.
	at org.apache.activemq.artemis.jms.client.ActiveMQMessage.checkProperty(ActiveMQMessage.java:992) ~[artemis-jms-client-2.6.4.jar:2.6.4]
	at org.apache.activemq.artemis.jms.client.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:763) ~[artemis-jms-client-2.6.4.jar:2.6.4]
...

Accordingly to this (see at the bottom) all dashes should be replaced with $dash$ but this is not happening. When I try to use raw opentracing java-jms it works as expected

I created repo that can be used to reproduce this issue
@pavolloffay
Copy link
Contributor

Could you please try 0.2.6 version?

If the java-jms works we are probably using a wrong version? Are you interested in submitting a fix for this?

@alextrs
Copy link
Author

alextrs commented Jul 29, 2019

I tried 0.2.6 and also the latest version, but still getting the same error

        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-jaeger-cloud-starter</artifactId>
            <version>2.0.0</version>
        </dependency>
        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-cloud-starter</artifactId>
            <version>0.3.2</version>
        </dependency>

Yep, I will submit a fix once I know what's wrong with it

@alextrs alextrs linked a pull request Jul 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with opentracing keys with dashes/hyphens and JMS. alextrs/java-spring-messaging
2 participants
@pavolloffay @alextrs