Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Props for StopsOverlay Component #59

Closed
PaulIvanov opened this issue Feb 6, 2020 · 2 comments · Fixed by #72
Closed

New Props for StopsOverlay Component #59

PaulIvanov opened this issue Feb 6, 2020 · 2 comments · Fixed by #72
Assignees
Labels
AS2 enhancement New feature or request MEDIUM-HIGH

Comments

@PaulIvanov
Copy link

Based on requirements for the new trimet.org project, we will need to be able to support custom icons for stops. There are multiple styles such as a fully colored version, an opaque version, etc.. We think the best way to get this behavior is to provide a prop that lets us inject the marker object.

Currently there is no way to prevent the popup when clicking on a stop. We would like an optional prop to hide pop-ups on the overlay.

Currently there is no onClickHandler for the markIcon itself. We need this in order to tie into other functionality within the trimet app, and we would expect the stopId would be propogated up.

@PaulIvanov
Copy link
Author

@fpurcell FYI

@fpurcell fpurcell self-assigned this Feb 7, 2020
@fpurcell fpurcell added enhancement New feature or request MEDIUM-HIGH labels Feb 7, 2020
@fpurcell
Copy link
Member

fpurcell commented Feb 7, 2020

Might also include the ability to display and show different stop icons on the map, based on the predominant mode of the vehicles serving a given stop. This is less of a priority than what Paul needs, but worth a mention in case the work to enable mode-based icons is incremental to that requested above.

Thoughts & Rationale:

  • http://ride.trimet.org has different stop icons on the map for different modes, which I find to be a valuable visual clue when looking at stops on the map.
  • so would love to eventually have different map icons for stops based on the 'mode' of the routes serving said stop. Can use the modes (enum / strings) should be those defined in the GTFS spec.
  • The trimet stop service (override used in place of OTP's Transit Index) has an additional "mode" element: https://newplanner.trimet.org/ws/ti/v0/index/stops?minLat=45.51&maxLat=45.52&minLon=-122.676&maxLon=-122.675
  • Important to make this component easy to configure to. So having a default icon supplied to the component to just customize all stop icons is a need. But maybe then mode based icons could be specified on top of this default icon to override for specified modes (e.g., again, need something simple to set all icons to a custom icon ... then something else to go further on specifying the individual mode icons).
  • Do we also need special colors (or icons) for highlighting a selected stop? And thus conversely graying-out unselected stops?
  • again, this is incremental and of lesser priority to just customizing all stop icons, as Paul is asking for above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AS2 enhancement New feature or request MEDIUM-HIGH
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants