Styling ModeButton title when component is selected #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
reviewed
Mar 20, 2020
| @@ -50,6 +50,10 @@ const TriMetStyled = styled.div` | |||
| padding: 4px 0px 0px; | |||
| font-size: 10px; | |||
| line-height: 12px; | |||
|
|
|||
| &.active { | |||
There was a problem hiding this comment.
We should not use classes like this with styled-components. Instead, the styled component should provide dynamic values based on the props that are sent. So this should be rewritten as:
text-decoration: ${props => props.selected && 'underline'}There was a problem hiding this comment.
Fair point. Except that props refers to the top-level styled component, in which case is SettingsSelectorPanel, and props contains the props of that component only.
evansiroky
reviewed
Mar 20, 2020
| @@ -36,7 +36,10 @@ const ModeButton = props => { | |||
| </Styled.ModeButton.Button> | |||
|
|
|||
| {title && showTitle && ( | |||
| <Styled.ModeButton.Title className={disabledClassName} title={title}> | |||
| <Styled.ModeButton.Title | |||
| className={`${activeClassName} ${disabledClassName}`} | |||
There was a problem hiding this comment.
We should not use classes like this with styled-components. Instead, the styled component should provide dynamic values based on the props that are sent. So this should be rewritten as:
<Styled.ModeButton.Title
selected={selected}
title={title}
>
evansiroky
requested changes
Mar 20, 2020
evansiroky
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor PR to allow the title of ModeButton to have a different style when the button is selected, as illustrated in the screenshot below.