From 13c943bca127e14015dd31c09bde9f00d734240e Mon Sep 17 00:00:00 2001 From: Shimmy Balsam Date: Wed, 9 Aug 2023 11:07:22 +0300 Subject: [PATCH] REVIEW: code review fixes --- src/components/tl/ucp/allgatherv/allgatherv.h | 4 ---- src/components/tl/ucp/allgatherv/allgatherv_ring.c | 11 ++++++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/components/tl/ucp/allgatherv/allgatherv.h b/src/components/tl/ucp/allgatherv/allgatherv.h index 834d380a72..e9faf27ed1 100644 --- a/src/components/tl/ucp/allgatherv/allgatherv.h +++ b/src/components/tl/ucp/allgatherv/allgatherv.h @@ -18,10 +18,6 @@ enum { extern ucc_base_coll_alg_info_t ucc_tl_ucp_allgatherv_algs[UCC_TL_UCP_ALLGATHERV_ALG_LAST + 1]; -ucc_status_t ucc_tl_ucp_allgatherv_ring_start(ucc_coll_task_t *task); - -void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *task); - ucc_status_t ucc_tl_ucp_allgatherv_ring_init_common(ucc_tl_ucp_task_t *task); ucc_status_t ucc_tl_ucp_allgatherv_init(ucc_tl_ucp_task_t *task); diff --git a/src/components/tl/ucp/allgatherv/allgatherv_ring.c b/src/components/tl/ucp/allgatherv/allgatherv_ring.c index cc4e316419..efc3a06099 100644 --- a/src/components/tl/ucp/allgatherv/allgatherv_ring.c +++ b/src/components/tl/ucp/allgatherv/allgatherv_ring.c @@ -34,9 +34,9 @@ void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *coll_task) while (task->tagged.send_posted < tsize) { send_idx = - ucc_ep_map_eval(task->subset.map,(trank - - task->tagged.send_posted + 1 + - tsize) % tsize); + ucc_ep_map_eval(task->subset.map, (trank - + task->tagged.send_posted + 1 + + tsize) % tsize); data_displ = ucc_coll_args_get_displacement( args, args->dst.info_v.displacements, send_idx) * rdt_size; @@ -47,8 +47,9 @@ void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *coll_task) rmem, sendto, team, task), task, out); recv_idx = - ucc_ep_map_eval(task->subset.map,(trank - - task->tagged.recv_posted + tsize) % tsize); + ucc_ep_map_eval(task->subset.map, (trank - + task->tagged.recv_posted + + tsize) % tsize); data_displ = ucc_coll_args_get_displacement( args, args->dst.info_v.displacements, recv_idx) * rdt_size;