[TF FE] Support complex tensors for Reverse,ReverseV2 operations #23395

MonalSD · 2024-03-12T06:35:28Z

Details:

Extended loader Reverse & ReverseV2 by propagating ComplexTypeMark from input to output and to represent output complex type tensor as a floating-point type tensor with an auxiliary dimension that concatenates real and imaginary parts of complex tensor.
Addressed [Good First Issue][TF FE]: Support complex tensors for Reverse,ReverseV2 operations #23235

rkazants · 2024-03-12T09:21:23Z

src/frontends/tensorflow_common/src/op/reverse.cpp

@@ -116,6 +135,26 @@ OutputVector translate_reverse_v2_op(const NodeContext& node) {
    std::vector<int64_t> axes;


please update above:

default_op_checks(node, 2, {"ReverseV2"}, true);

Otherwise, it means complex type is not support for ReverseV2

rkazants · 2024-03-12T09:23:22Z

src/frontends/tensorflow_common/src/op/reverse.cpp

+        auto reversed_real_part = translate_reverse_base_op(node, input_real, axes);
+        auto reversed_imag_part = translate_reverse_base_op(node, input_imag, axes);
+
+        auto reversed = make_shared<v0::Complex>(reversed_real_part[0], reversed_imag_part[0]);


we do not have Complex operation in our OV opset.

rkazants · 2024-03-12T09:24:35Z

tests/layer_tests/tensorflow_tests/test_tf_Reverse.py

@@ -30,3 +31,49 @@ def create_reverse_net(self, shape, dims):
    def test_reverse_basic(self, params, ie_device, precision, ir_version, temp_dir):
        self._test(*self.create_reverse_net(**params),
                   ie_device, precision, ir_version, temp_dir=temp_dir)
+
+class TestReverseComplex(CommonTFLayerTest):


please run this layer test locally on your machine. It should not be passing now because we have a build issue in the code above:)

p-wysocki · 2024-03-12T10:18:04Z

build_jenkins

MonalSD · 2024-03-14T07:18:15Z

@rkazants can you please guide me on how to run tests locally, I tried but I'm not able to build it.

rkazants · 2024-03-14T08:34:34Z

@rkazants can you please guide me on how to run tests locally, I tried but I'm not able to build it.

Hi @MonalSD,

Please build OpenVINO locally on your machine. In build directory you should receive wheel directory with build openvino wheel package that you should install for layer tests. How yo build OV, see wiki here: https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/build.md

After successful build and installation, install all reqs for running layer tests:

go to layer_test directory https://github.com/openvinotoolkit/openvino/tree/master/tests/layer_tests
install reqs: pip install -r requirements.txt
run test pytest tensorflow_tests/test_tf_Unique.py -m precommit_tf_fe

Best regards,
Roman

MonalSD · 2024-03-15T08:14:27Z

@rkazants can you please guide me on how to run tests locally, I tried but I'm not able to build it.

Hi @MonalSD,

Please build OpenVINO locally on your machine. In build directory you should receive wheel directory with build openvino wheel package that you should install for layer tests. How yo build OV, see wiki here: https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/build.md

After successful build and installation, install all reqs for running layer tests:

go to layer_test directory https://github.com/openvinotoolkit/openvino/tree/master/tests/layer_tests

install reqs: pip install -r requirements.txt

run test pytest tensorflow_tests/test_tf_Unique.py -m precommit_tf_fe

Best regards, Roman

Hie @rkazants I tried to build it ... It's still failing I'll try again and get back to you on this.

rkazants · 2024-03-15T09:45:22Z

@rkazants can you please guide me on how to run tests locally, I tried but I'm not able to build it.

Hi @MonalSD,
Please build OpenVINO locally on your machine. In build directory you should receive wheel directory with build openvino wheel package that you should install for layer tests. How yo build OV, see wiki here: https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/build.md
After successful build and installation, install all reqs for running layer tests:

go to layer_test directory https://github.com/openvinotoolkit/openvino/tree/master/tests/layer_tests

install reqs: pip install -r requirements.txt

run test pytest tensorflow_tests/test_tf_Unique.py -m precommit_tf_fe

Best regards, Roman

Hie @rkazants I tried to build it ... It's still failing I'll try again and get back to you on this.

Please share what kind of error are you getting? And what step?

MonalSD · 2024-03-15T09:52:46Z

o
I'm not getting any error, the terminal is just crashing. I'm running the following command:

cmake --build . --parallel : for this command it's crashing
cmake --build . --parallel 8: for this command it's giving error 2

rkazants · 2024-03-15T09:58:07Z

o
I'm not getting any error, the terminal is just crashing. I'm running the following command:

cmake --build . --parallel : for this command it's crashing

cmake --build . --parallel 8: for this command it's giving error 2

try cmake --build . or cmake --build . --parallel 2 to have less threads for building

MonalSD · 2024-03-16T13:12:53Z

o
I'm not getting any error, the terminal is just crashing. I'm running the following command:

cmake --build . --parallel : for this command it's crashing

cmake --build . --parallel 8: for this command it's giving error 2

try cmake --build . or cmake --build . --parallel 2 to have less threads for building

@rkazants I tried to build it for 3-4 times but it's now failing on ERROR2.

MonalSD · 2024-03-18T13:15:42Z

@rkazants I tried a lot build isn't passing is there any other way to resolve this? So, that we can move forward

rkazants · 2024-03-19T09:55:09Z

@rkazants I tried a lot build isn't passing is there any other way to resolve this? So, that we can move forward

Hi @MonalSD,

Here are my steps I follow on Windows:

cmake -G "Visual Studio 16 2019" -A x64 -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON=ON -DENABLE_TESTS=ON ..

after that I open created sln file in MSVS  and build inside

Here are my steps on Linux:

cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON=ON -DENABLE_TESTS=ON ..
make -j 8

MonalSD · 2024-03-25T05:20:52Z

@rkazants I tried a lot build isn't passing is there any other way to resolve this? So, that we can move forward

Hi @MonalSD,

Here are my steps I follow on Windows:
cmake -G "Visual Studio 16 2019" -A x64 -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON=ON -DENABLE_TESTS=ON ..

after that I open created sln file in MSVS  and build inside
Here are my steps on Linux:
cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON=ON -DENABLE_TESTS=ON ..
make -j 8

@rkazants tried this also still the build is failing

MonalSD · 2024-04-02T13:04:45Z

@rkazants please help on resolving this

github-actions · 2024-04-21T00:19:41Z

This PR will be closed in a week because of 2 weeks of no activity.

MonalSD · 2024-04-21T02:08:05Z

@rkazants how to proceed further.

MonalSD · 2024-04-21T16:08:56Z

@rkazants please review

github-actions · 2024-05-07T00:18:23Z

This PR will be closed in a week because of 2 weeks of no activity.

github-actions · 2024-05-14T00:18:32Z

This PR was closed because it has been stalled for 2 week with no activity.

Support complex tensors for Reverse,ReverseV2 operations

2491202

MonalSD requested a review from a team as a code owner March 12, 2024 06:35

github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Mar 12, 2024

rkazants reviewed Mar 12, 2024

View reviewed changes

Addressing changes

8c19062

rkazants reviewed Mar 12, 2024

View reviewed changes

rkazants added the ExternalPR External contributor label Mar 12, 2024

Addressing changes for Concat

1182b7c

p-wysocki linked an issue Mar 12, 2024 that may be closed by this pull request

[Good First Issue][TF FE]: Support complex tensors for Reverse,ReverseV2 operations #23235

Open

rkazants self-assigned this Mar 13, 2024

rkazants changed the title ~~Support complex tensors for Reverse,ReverseV2 operations~~ [TF FE] Support complex tensors for Reverse,ReverseV2 operations Mar 14, 2024

Merge branch 'openvinotoolkit:master' into 23235issue

3989f99

github-actions bot added the Stale label Apr 21, 2024

Fix

606831c

github-actions bot removed the Stale label Apr 22, 2024

github-actions bot added the Stale label May 7, 2024

github-actions bot closed this May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TF FE] Support complex tensors for Reverse,ReverseV2 operations #23395

[TF FE] Support complex tensors for Reverse,ReverseV2 operations #23395

MonalSD commented Mar 12, 2024

rkazants Mar 12, 2024

rkazants Mar 12, 2024

rkazants Mar 12, 2024

p-wysocki commented Mar 12, 2024

MonalSD commented Mar 14, 2024

rkazants commented Mar 14, 2024

MonalSD commented Mar 15, 2024

rkazants commented Mar 15, 2024

MonalSD commented Mar 15, 2024

rkazants commented Mar 15, 2024

MonalSD commented Mar 16, 2024

MonalSD commented Mar 18, 2024

rkazants commented Mar 19, 2024

MonalSD commented Mar 25, 2024

MonalSD commented Apr 2, 2024

github-actions bot commented Apr 21, 2024

MonalSD commented Apr 21, 2024

MonalSD commented Apr 21, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 14, 2024

		@@ -116,6 +135,26 @@ OutputVector translate_reverse_v2_op(const NodeContext& node) {
		std::vector<int64_t> axes;

[TF FE] Support complex tensors for Reverse,ReverseV2 operations #23395

[TF FE] Support complex tensors for Reverse,ReverseV2 operations #23395

Conversation

MonalSD commented Mar 12, 2024

Details:

rkazants Mar 12, 2024

Choose a reason for hiding this comment

rkazants Mar 12, 2024

Choose a reason for hiding this comment

rkazants Mar 12, 2024

Choose a reason for hiding this comment

p-wysocki commented Mar 12, 2024

MonalSD commented Mar 14, 2024

rkazants commented Mar 14, 2024

MonalSD commented Mar 15, 2024

rkazants commented Mar 15, 2024

MonalSD commented Mar 15, 2024

rkazants commented Mar 15, 2024

MonalSD commented Mar 16, 2024

MonalSD commented Mar 18, 2024

rkazants commented Mar 19, 2024

MonalSD commented Mar 25, 2024

MonalSD commented Apr 2, 2024

github-actions bot commented Apr 21, 2024

MonalSD commented Apr 21, 2024

MonalSD commented Apr 21, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 14, 2024